-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xbox Node Controls #274
Open
soumya-khanna
wants to merge
31
commits into
master
Choose a base branch
from
user/wang-edward/220/drivetrain-xbox
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Xbox Node Controls #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drivetrain ros2 control code for rover --------- Co-authored-by: ColinToft <[email protected]> Co-authored-by: Andrew Zhao <[email protected]> Co-authored-by: Keyon Jerome <[email protected]>
Nafis and Nico: * loaded into gazebo
* add macros to simulate sensors * add more params to yaml * add lidar at front
* simple costmap using 2 cameras, 1 lidar * costmap layers * change sensors used * allow clearing obstacles
please point this at comp-2024 branch and try to rebase your branch on comp-2024 if possible (be careful when doing so to not mess up your git history!) |
soumya-khanna
force-pushed
the
user/wang-edward/220/drivetrain-xbox
branch
from
September 13, 2024 19:56
49b41d0
to
fad2bff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This branch pulls in the latest code that allows the xbox controller to control the mars rover.
Testing
The testing was performed on the gazebo simulation. A possible issue we found was that the simulation lagged quite a bit when testing, which affected our ability to confidently conclude whether or not the speed control works.
Plan & Details
The plan below has details about how to run the node, and test it, as well as how the controls work
https://soumyakhanna.notion.site/XBox-Controller-Movement-Design-Plan-83ad9293d39144619543e5cf6105b0de