Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize variables for cantilever vibration mode #651

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

TomokiMochizuki
Copy link
Member

Related issues

NaN

Description

  • angular_velocity_cantilever_rad_s_
  • euler_angular_cantilever_rad_

are not initialized in *.hpp file.

Test results

See CI

Impact

Unless the initialization of the variables listed above, simulations could not provide accurate information.

Supplementary information

Provide any supplementary information.

@TomokiMochizuki TomokiMochizuki requested review from sksat and a team as code owners June 27, 2024 01:08
@TomokiMochizuki TomokiMochizuki requested review from 200km, seki-hiro, suzuki-toshihir0, t-hosonuma and conjikidow and removed request for a team June 27, 2024 01:08
@TomokiMochizuki TomokiMochizuki self-assigned this Jun 27, 2024
@200km 200km changed the title [hotfix] initialize variables for cantilever vibration mode Initialize variables for cantilever vibration mode Jun 27, 2024
Copy link
Member

@200km 200km left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます。
リリース後のmainへの修正ではないので、管理上の都合で[hotfix]は外しました。

@TomokiMochizuki
Copy link
Member Author

修正ありがとうございます。 リリース後のmainへの修正ではないので、管理上の都合で[hotfix]は外しました。

ありがとうございます。

@TomokiMochizuki TomokiMochizuki merged commit 3a4877e into develop Jun 27, 2024
11 checks passed
@TomokiMochizuki TomokiMochizuki deleted the hotfix/initialize-variables branch June 27, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants