u3: inline cell deconstruction #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-levan
approved these changes
Oct 13, 2023
pkova
added a commit
that referenced
this pull request
Nov 14, 2023
This PR fixes my mistake in #536. Thanks for @liam-fitzgerald for flagging that this broke debug builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts
u3r_cell()/trel/&c inline functions andu3x_cell()/trel/&c to macros. This is mostly just a straightforward optimization of frequently used deconstructors, as prelude to optimizing all the jet-interface (u3w*) functions.In the case of
u3x_atom()the previously-defined macro repeated its argument, which is a bad pattern as that "argument" is often a call to another function. It has now been switched to an inline function.