Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u3: redeclare inline u3x_atom for linkability #552

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

joemfb
Copy link
Member

@joemfb joemfb commented Nov 14, 2023

This PR fixes my mistake in #536. Thanks for @liam-fitzgerald for flagging that this broke debug builds.

@joemfb joemfb requested a review from a team as a code owner November 14, 2023 13:59
Copy link
Contributor

@matthew-levan matthew-levan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bazel build :urbit --compilation_mode=dbg works now, thanks for fixing this. @mopfel-winrux @pkova and @yosoyubik were running into this yesterday.

@pkova pkova merged commit 195029d into develop Nov 14, 2023
5 checks passed
@pkova pkova deleted the jb/fix-inline-u3x_atom branch November 14, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants