test: migrate to createRuleTestCaseFunction

.changeset/fluffy-dolls-pump.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-import-x": patch
+---
+
+fix(first): add missing value in options type

.github/workflows/ci.yml

@@ -24,7 +24,7 @@ jobs:
         eslint:
           - '8.56'
           - '8'
-          - '9'
+          - '9.14'
 
         include:
           - executeLint: true

src/rules/first.ts

@@ -20,9 +20,11 @@ function isPossibleDirective(node: TSESTree.ProgramStatement) {
   )
 }
 
+type Options = 'absolute-first' | 'disable-absolute-first'
+
 type MessageId = 'absolute' | 'order'
 
-export = createRule<['absolute-first'?], MessageId>({
+export = createRule<[Options?], MessageId>({
   name: 'first',
   meta: {
     type: 'suggestion',

src/rules/group-exports.ts

@@ -35,7 +35,9 @@ function accessorChain(node: TSESTree.MemberExpression) {
   return chain
 }
 
-export = createRule<[], 'ExportNamedDeclaration' | 'AssignmentExpression'>({
+type MessageId = 'ExportNamedDeclaration' | 'AssignmentExpression'
+
+export = createRule<[], MessageId>({
   name: 'group-exports',
   meta: {
     type: 'suggestion',

test/rules/consistent-type-specifier-style.spec.ts

@@ -1,11 +1,14 @@
 import { RuleTester as TSESLintRuleTester } from '@typescript-eslint/rule-tester'
 import { TSESTree } from '@typescript-eslint/utils'
 
-import { parsers, test } from '../utils'
+import { parsers, createRuleTestCaseFunction } from '../utils'
+import type { RunTests } from '../utils'
 
 import rule from 'eslint-plugin-import-x/rules/consistent-type-specifier-style'
 
-const COMMON_TESTS = {
+const test = createRuleTestCaseFunction<typeof rule>()
+
+const COMMON_TESTS: RunTests<typeof rule> = {
   valid: [
     //
     // prefer-top-level
@@ -248,7 +251,7 @@ import {
   ],
 } as const
 
-const TS_ONLY = {
+const TS_ONLY: RunTests<typeof rule> = {
   valid: [
     //
     // always valid
@@ -258,7 +261,7 @@ const TS_ONLY = {
   invalid: [],
 }
 
-const FLOW_ONLY = {
+const FLOW_ONLY: RunTests<typeof rule> = {
   valid: [
     //
     // prefer-top-level

test/rules/default.spec.ts

@@ -2,13 +2,20 @@ import path from 'node:path'
 
 import { RuleTester as TSESLintRuleTester } from '@typescript-eslint/rule-tester'
 
-import { test, SYNTAX_CASES, parsers } from '../utils'
+import {
+  createRuleTestCaseFunction,
+  SYNTAX_VALID_CASES,
+  parsers,
+} from '../utils'
+import type { RunTests } from '../utils'
 
 import rule from 'eslint-plugin-import-x/rules/default'
 import { CASE_SENSITIVE_FS } from 'eslint-plugin-import-x/utils'
 
 const ruleTester = new TSESLintRuleTester()
 
+const test = createRuleTestCaseFunction<typeof rule>()
+
 ruleTester.run('default', rule, {
   valid: [
     test({
@@ -123,7 +130,7 @@ ruleTester.run('default', rule, {
       },
     }),
 
-    ...SYNTAX_CASES,
+    ...(SYNTAX_VALID_CASES as RunTests<typeof rule>['valid']),
   ],
 
   invalid: [
@@ -138,9 +145,10 @@ ruleTester.run('default', rule, {
       code: 'import baz from "./named-exports";',
       errors: [
         {
-          message:
-            'No default export found in imported module "./named-exports".',
-          type: 'ImportDefaultSpecifier',
+          messageId: 'noDefaultExport',
+          data: {
+            module: './named-exports',
+          },
         },
       ],
     }),
@@ -149,31 +157,64 @@ ruleTester.run('default', rule, {
     test({
       code: 'export baz from "./named-exports"',
       languageOptions: { parser: require(parsers.BABEL) },
-      errors: ['No default export found in imported module "./named-exports".'],
+      errors: [
+        {
+          messageId: 'noDefaultExport',
+          data: {
+            module: './named-exports',
+          },
+        },
+      ],
     }),
     test({
       code: 'export baz, { bar } from "./named-exports"',
       languageOptions: { parser: require(parsers.BABEL) },
-      errors: ['No default export found in imported module "./named-exports".'],
+      errors: [
+        {
+          messageId: 'noDefaultExport',
+          data: {
+            module: './named-exports',
+          },
+        },
+      ],
     }),
     test({
       code: 'export baz, * as names from "./named-exports"',
       languageOptions: { parser: require(parsers.BABEL) },
-      errors: ['No default export found in imported module "./named-exports".'],
+      errors: [
+        {
+          messageId: 'noDefaultExport',
+          data: {
+            module: './named-exports',
+          },
+        },
+      ],
     }),
     // exports default from a module with no default
     test({
       code: 'import twofer from "./broken-trampoline"',
       languageOptions: { parser: require(parsers.BABEL) },
       errors: [
-        'No default export found in imported module "./broken-trampoline".',
+        {
+          messageId: 'noDefaultExport',
+          data: {
+            module: './broken-trampoline',
+          },
+        },
       ],
     }),
 
     // #328: * exports do not include default
     test({
       code: 'import barDefault from "./re-export"',
-      errors: ['No default export found in imported module "./re-export".'],
+      errors: [
+        {
+          messageId: 'noDefaultExport',
+          data: {
+            module: './re-export',
+          },
+        },
+      ],
     }),
   ],
 })
@@ -190,7 +231,12 @@ if (!CASE_SENSITIVE_FS) {
       test({
         code: 'import bar from "./Named-Exports"',
         errors: [
-          'No default export found in imported module "./Named-Exports".',
+          {
+            messageId: 'noDefaultExport',
+            data: {
+              module: './Named-Exports',
+            },
+          },
         ],
       }),
     ],
@@ -321,7 +367,14 @@ describe('TypeScript', () => {
           'import-x/parsers': { [parsers.TS]: ['.ts'] },
           'import-x/resolver': { 'eslint-import-resolver-typescript': true },
         },
-        errors: ['No default export found in imported module "./typescript".'],
+        errors: [
+          {
+            messageId: 'noDefaultExport',
+            data: {
+              module: './typescript',
+            },
+          },
+        ],
       }),
       test({
         code: `import React from "./typescript-export-assign-default-namespace"`,
@@ -331,7 +384,12 @@ describe('TypeScript', () => {
           'import-x/resolver': { 'eslint-import-resolver-typescript': true },
         },
         errors: [
-          'No default export found in imported module "./typescript-export-assign-default-namespace".',
+          {
+            messageId: 'noDefaultExport',
+            data: {
+              module: './typescript-export-assign-default-namespace',
+            },
+          },
         ],
       }),
       test({
@@ -342,7 +400,12 @@ describe('TypeScript', () => {
           'import-x/resolver': { 'eslint-import-resolver-typescript': true },
         },
         errors: [
-          'No default export found in imported module "./typescript-export-as-default-namespace".',
+          {
+            messageId: 'noDefaultExport',
+            data: {
+              module: './typescript-export-as-default-namespace',
+            },
+          },
         ],
       }),
       test({
@@ -362,8 +425,10 @@ describe('TypeScript', () => {
         },
         errors: [
           {
-            message:
-              'No default export found in imported module "./typescript-export-as-default-namespace".',
+            messageId: 'noDefaultExport',
+            data: {
+              module: './typescript-export-as-default-namespace',
+            },
             line: 1,
             column: 8,
             endLine: 1,

test/rules/dynamic-import-chunkname.spec.ts

@@ -1,39 +1,42 @@
 import { RuleTester as TSESLintRuleTester } from '@typescript-eslint/rule-tester'
 import { TSESTree } from '@typescript-eslint/utils'
 
-import { SYNTAX_CASES, parsers } from '../utils'
+import { SYNTAX_VALID_CASES, parsers } from '../utils'
+import type { GetRuleModuleOptions } from '../utils'
 
 import rule from 'eslint-plugin-import-x/rules/dynamic-import-chunkname'
 
 const ruleTester = new TSESLintRuleTester()
 
+type RuleOptions = GetRuleModuleOptions<typeof rule>
+
 const pickyCommentFormat = '[a-zA-Z-_/.]+'
 
 const options = [
   {
     importFunctions: ['dynamicImport'],
   },
-] as const
+] as const satisfies RuleOptions
 
 const pickyCommentOptions = [
   {
     importFunctions: ['dynamicImport'],
     webpackChunknameFormat: pickyCommentFormat,
   },
-] as const
+] as const satisfies RuleOptions
 
 const allowEmptyOptions = [
   {
     importFunctions: ['dynamicImport'],
     allowEmpty: true,
   },
-] as const
+] as const satisfies RuleOptions
 
 const multipleImportFunctionOptions = [
   {
     importFunctions: ['dynamicImport', 'definitelyNotStaticImport'],
   },
-] as const
+] as const satisfies RuleOptions
 
 const babelParser = require(parsers.BABEL)
 
@@ -425,7 +428,7 @@ ruleTester.run('dynamic-import-chunkname', rule, {
       options,
       languageOptions: { parser: babelParser },
     },
-    ...SYNTAX_CASES,
+    ...SYNTAX_VALID_CASES,
   ],
 
   invalid: [