-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: migrate to createRuleTestCaseFunction
#184
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: b130ac4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This comment was marked as outdated.
This comment was marked as outdated.
@@ -24,7 +24,7 @@ jobs: | |||
eslint: | |||
- '8.56' | |||
- '8' | |||
- '9' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yesterday the task was working
It seems an issue with eslint
: eslint/eslint#19134.
Relative eslint-plugin-unicorn
issue: sindresorhus/eslint-plugin-unicorn#2496
I assume that the following steps in CI workflows ends up installing the last version of eslint
:
eslint-plugin-import-x/.github/workflows/ci.yml
Lines 56 to 63 in 14fc608
- name: Install ESLint ${{ matrix.eslint }} | |
run: | | |
yarn add -D --ignore-engines eslint@${{ matrix.eslint }} | |
- name: Install Dependencies | |
run: yarn --ignore-engines | |
env: | |
SKIP_YARN_COREPACK_CHECK: 1 |
eslint-plugin-import-x/.github/workflows/ci.yml
Lines 24 to 27 in 14fc608
eslint: | |
- '8.56' | |
- '8' | |
- '9' |
Replacing 9
with 9.14
makes CI green again.
I just want to report that on the failing CI the eslint
version printed in the error is 9.8.0
which seems wrong since the error is present on 9.15.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the issue comes from the typescript-eslint
now. Let's wait and see if bumping typescript-eslint
would be possible.
You can either continue to push to this PR or subsequent PRs, I am OK with both. If you are going to continue to push to this PR, it would be better to convert this PR to a draft. |
I migrated the first 10 rules test files.
Aside from a fix on
first
rule where value was missing inOptions
type everything should work like a charm.(I added a changeset but unless someone is extracting the type from the rule export nothing will change on user land)
Do you prefer that I continue to push on this PR or do you prefer that I open subsequent PRs to divide the review effort?