Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate to createRuleTestCaseFunction #184

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

marcalexiei
Copy link

I migrated the first 10 rules test files.

Aside from a fix on first rule where value was missing in Options type everything should work like a charm.
(I added a changeset but unless someone is extracting the type from the rule export nothing will change on user land)

Do you prefer that I continue to push on this PR or do you prefer that I open subsequent PRs to divide the review effort?

Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: b130ac4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-import-x Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Nov 15, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@marcalexiei

This comment was marked as outdated.

@@ -24,7 +24,7 @@ jobs:
eslint:
- '8.56'
- '8'
- '9'
Copy link
Author

@marcalexiei marcalexiei Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesterday the task was working

Today is not

It seems an issue with eslint: eslint/eslint#19134.
Relative eslint-plugin-unicorn issue: sindresorhus/eslint-plugin-unicorn#2496

I assume that the following steps in CI workflows ends up installing the last version of eslint:

- name: Install ESLint ${{ matrix.eslint }}
run: |
yarn add -D --ignore-engines eslint@${{ matrix.eslint }}
- name: Install Dependencies
run: yarn --ignore-engines
env:
SKIP_YARN_COREPACK_CHECK: 1

eslint:
- '8.56'
- '8'
- '9'

Replacing 9 with 9.14 makes CI green again.


I just want to report that on the failing CI the eslint version printed in the error is 9.8.0 which seems wrong since the error is present on 9.15.0.

Copy link
Collaborator

@SukkaW SukkaW Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the issue comes from the typescript-eslint now. Let's wait and see if bumping typescript-eslint would be possible.

@SukkaW
Copy link
Collaborator

SukkaW commented Nov 16, 2024

Do you prefer that I continue to push on this PR or do you prefer that I open subsequent PRs to divide the review effort?

You can either continue to push to this PR or subsequent PRs, I am OK with both.

If you are going to continue to push to this PR, it would be better to convert this PR to a draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants