Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libraries on WCOSS2 to ip/4.0.0 w3emc/2.12.0 and all platforms to fms/2024.01 #2431

Merged
merged 31 commits into from
Sep 25, 2024

Conversation

BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Sep 9, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Bump libraries on WCOSS2 to ip/4.0.0 w3emc/2.12.0 and fms/2024.01

Commit Message:

* UFSWM - Bump libraries on WCOSS2 to ip/4.0.0 w3emc/2.12.0 and fms/2024.01

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.
    • cpld_control_sfs intel

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@BrianCurtis-NOAA
Copy link
Collaborator Author

@XiaqiongZhou-NOAA is there any reason why cpld_control_sfs intel might fail in comparison? Are there any special FMS features that it uses?

Thanks for your help!

@BrianCurtis-NOAA
Copy link
Collaborator Author

There is also a possibility that the latest prod switch brought in an issue where we can just create new baselines for that test and be good to go.

@BrianCurtis-NOAA
Copy link
Collaborator Author

@XiaqiongZhou-NOAA I tested the current develop branch with that test on wcoss2 and it also failed, so i'll go ahead and regenerate that baseline and re-compare with these changes. I'll let you know if any issue crops up again.

@jkbk2004
Copy link
Collaborator

@zach1221 @FernandoAndrade-NOAA @RatkoVasic-NOAA can we apply ufs_common update in this pr for fms2024.01? I understand tests are done at hera, hercules, orion. But we need to make sure the new FMS is ready on Gaea, jet, and Derecho as well. @RatkoVasic-NOAA do we have any issue on those machines?

@RatkoVasic-NOAA
Copy link
Collaborator

@jkbk2004 I finished all machines (except of GCP, for which we don't have resources). You can start testing all machines with new FMS environment. Here is list of directories.

@BrianCurtis-NOAA
Copy link
Collaborator Author

I can bump the ufs_common, sure.

@jkbk2004
Copy link
Collaborator

@BrianCurtis-NOAA I think we should be able to commit this pr today. Can you update ufs_common as well?

@BrianCurtis-NOAA
Copy link
Collaborator Author

I'm going to run WCOSS2 RT again as the FMS location was put into a default location. Please run on a GNU supported platform to verify it's all good for RDHPCS testing.

@BrianCurtis-NOAA BrianCurtis-NOAA changed the title [WCOSS2] Bump libraries on WCOSS2 to ip/4.0.0 w3emc/2.12.0 and fms/2024.01 Bump libraries on WCOSS2 to ip/4.0.0 w3emc/2.12.0 and all platforms to fms/2024.01 Sep 20, 2024
@jkbk2004
Copy link
Collaborator

@zach1221 @FernandoAndrade-NOAA I am running on hera and hercules. Go ahead to pick up other machines.

@BrianCurtis-NOAA BrianCurtis-NOAA self-assigned this Sep 20, 2024
@BrianCurtis-NOAA
Copy link
Collaborator Author

@AlexanderRichert-NOAA can you install FMS 2024.01 on Acorn's spack stack 1.6.0 ?

@BrianCurtis-NOAA
Copy link
Collaborator Author

@AlexanderRichert-NOAA I can't get the following two libraries to load via your spack build:
{["g2"] = "3.5.1"},
{["g2tmpl"] = "1.13.0"},

@RatkoVasic-NOAA
Copy link
Collaborator

RatkoVasic-NOAA commented Sep 20, 2024

@AlexanderRichert-NOAA I used this in spack.yaml for all [email protected] installations:

nco, met and met+ were needed for SRW, you probably don't need that in WCOSS2.

@AlexanderRichert-NOAA
Copy link
Collaborator

Sorry, I installed those then forget to update here. Please try the same environment again.

@BrianCurtis-NOAA BrianCurtis-NOAA added No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Sep 23, 2024
@FernandoAndrade-NOAA FernandoAndrade-NOAA added jenkins-ort run ORT testing and removed jenkins-ort run ORT testing labels Sep 23, 2024
@BrianCurtis-NOAA
Copy link
Collaborator Author

How is the ORT coming along?

@FernandoAndrade-NOAA
Copy link
Collaborator

They needed to be rerun manually due to disk quota, they should hopefully finish soon.

@DusanJovic-NOAA
Copy link
Collaborator

Why do we run ORT if there are no code changes and no baseline changes?

@jkbk2004 jkbk2004 merged commit 2ccc549 into ufs-community:develop Sep 25, 2024
3 checks passed
@jkbk2004 jkbk2004 mentioned this pull request Sep 25, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install FMS 2024.01 and test with UFSWM
7 participants