-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Modulefile updates for NOAA Cloud Rocky 8 platforms #1129
[develop] Modulefile updates for NOAA Cloud Rocky 8 platforms #1129
Conversation
@gspetro-NOAA @christinaholtNOAA - |
Fundamental tests successfully completed on Azure Rocky8 with the following timings:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
NOAA AWS Rocky fundamental tests complete (with increased times for workflow tasks not included in this PR):
|
@MichaelLueken - the changes for CSPs Rocky 8 were merged into the UFS WM, and the WM Updates for NOAA Cloud Rocky 8 platforms #2436 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me! Since these changes are only to The NOAA cloud modulefiles, and the Jenkins tests aren't run on NOAA Cloud (and all of EPIC's cloud compute are currently frozen), I will approve these changes and merge them now. Thanks!
DESCRIPTION OF CHANGES:
Updated modulefiles o use NOAA Cloud Rocky8 platforms
Files changed:
-modulefiles/build_noaacloud_intel.lua (loading spack-stack procedure change)
-modulefiles/wflow_noaacloud.lua
(!) Note inclusion of loading gnu compiler in build_noaacloud_intel.lua with the successive unloading.
Gnu compiler is required for loading the intel/2023.2.0 module on Rocky8. However, this created a problem when building spack-stack. Unloading the gnu compiler right after the intel module is loaded solves the problem. This approach has been used to build spack-stack-rocky8/spack-stack-1.6.0 as well.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
Possibly need documentation updates for NOAA CSPs
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):