-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop]: Document process for changing number of vertical levels #888
Conversation
Co-authored-by: Michael Kavulich <[email protected]>
Co-authored-by: Michael Kavulich <[email protected]>
Co-authored-by: Michael Kavulich <[email protected]>
Co-authored-by: Michael Kavulich <[email protected]>
…er-app into text/ug-updates
Co-authored-by: Michael Kavulich <[email protected]>
…er-app into text/ug-updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your work on this PR, @gspetro-NOAA!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gspetro-NOAA - Thank you very much for going into great detail on how to change the number of vertical levels in the SRW App! These changes look good to me! Approving now.
DESCRIPTION OF CHANGES:
This PR adds a section to the LAMGrid chapter explaining how to change the number of vertical levels in an SRW App experiment
Type of change
TESTS CONDUCTED:
None required. This is a documentation-only PR. However, I ran through an experiment using the process in the docs to generate ak/bk for 128 levels. I used the resulting VCOORD_FILE to run the
community.config.yaml
experiment with 128 vertical levels instead of the usual 65. The workflow completed successfully and the results can be viewed on Hera here:/scratch2/NAGAPE/epic/Gillian.Petro/expt_dirs/test_vert2
The human-friendly version of the docs in my fork can be viewed here: https://srw-ug.readthedocs.io/en/text-grid/CustomizingTheWorkflow/LAMGrids.html.
DEPENDENCIES:
PR #880
DOCUMENTATION:
N/A (all docs)
ISSUE:
It seems that PR #813 and the updates in this PR at least partially resolve Issue #397.
I think there was the hope that we could simplify the process for users (e.g., by setting
levp
/npz
and other required variables inconfig.yaml
and generating the ak/bk automatically from that), so it may be best to check with @JeffBeck-NOAA and @gsketefian as to whether to close this issue and open an enhancement issue or just keep this issue open.CHECKLIST