Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify their own vertical coordinate configuration #397

Closed
mkavulich opened this issue Oct 5, 2022 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@mkavulich
Copy link
Collaborator

Original issue opened by @JeffBeck-NOAA migrated from regional_workflow repository: ufs-community/regional_workflow#524

Description

Currently the vertical coordinate configuration is hard-coded for the UFS SRW App. We should introduce the capability for users to specify their own vertical coordinate configuration.

Solution

Add an option to set npz_type in the namelist to 'input', which then allows a user to place a text file with the vertical level ak/bks in the run directory to be read in by the model. Also, from @BenjaminBlake-NOAA: "There is a small block of code changes to fv_eta.F90 in the ufs-weather-model code that allows you to use npz_type = 'input'".

Need to confirm whether defining 'npz' or 'levp' values in the namelist are still required when using this method.

Requirements**

Acceptance Criteria (Definition of Done)

@gspetro-NOAA
Copy link
Collaborator

Was this issue resolved by PR #813 and PR #888 ? Seems like we could close it.

@mkavulich
Copy link
Collaborator Author

@gspetro-NOAA Given that you tested the capability and it works with #888, I'd say this is complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants