Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make UnitImageFactory synchronized. #12649

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Make UnitImageFactory synchronized. #12649

merged 1 commit into from
Jun 15, 2024

Commits on Jun 15, 2024

  1. Make UnitImageFactory synchronized. 

    It's already used from multiple threads, per triplea-game#12623, so making the methods that access internal collections synchronized to fix ConcurrentModificationException.

This is using the lombok synchronized annotation which is better than the Java keyword since it keeps an internal lock object.
    @asvitkine
    asvitkine committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    d027269 View commit details
    Browse the repository at this point in the history