Make UnitImageFactory synchronized. #12649
Merged
+37
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's already used from multiple threads, per triplea-game#12623, so making the methods that access internal collections synchronized to fix ConcurrentModificationException. This is using the lombok synchronized annotation which is better than the Java keyword since it keeps an internal lock object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's already used from multiple threads, per #12623, so making the methods that access internal collections synchronized to fix ConcurrentModificationException.
This is using the lombok synchronized annotation which is better than the Java keyword since it keeps an internal lock object.
Fixes #12623
Notes to Reviewer