Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix another cause of "Could not find step name" #11838

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Fix another cause of "Could not find step name" #11838

merged 4 commits into from
Aug 1, 2023

Commits on Jul 31, 2023

  1. Fix another cause of "Could not find step name" 

    The error would happen when there are multiple casualty steps at first, but when we get to that point in combat, some of those get removed (due units dying and not having a counterattack) and we may end up with a generic casualty step. To fix this, we keep track of which firing units each casualty step had and match based on those.
    @asvitkine
    asvitkine committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    4669ec9 View commit details
    Browse the repository at this point in the history

  2. Fix tests.

    @asvitkine
    asvitkine committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    71bef1b View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Add a test.

    @asvitkine
    asvitkine committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d8a544b View commit details
    Browse the repository at this point in the history

  2. Improve comment.

    @asvitkine
    asvitkine committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    f7efcd3 View commit details
    Browse the repository at this point in the history