Fix another cause of "Could not find step name" #11838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error would happen when there are multiple casualty steps at first, but when we get to that point in combat, some of those get removed (due units dying and not having a counterattack) and we may end up with a generic casualty step. To fix this, we keep track of which firing units each casualty step had and match based on those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary & Additional Notes
The error would happen when there are multiple casualty steps at first, but when we get to that point in combat, some of those get removed (due units dying and not having a counterattack) and we may end up with a generic casualty step. To fix this, we keep track of which firing units each casualty step had and match based on those.
Adds a test for the fix that's confirmed to fail without it.
Note: This is fixing a 2.6 bug, so no release notes.
Fixes another cause of: #11617
Release Note