Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE with returnFire field. #11729

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Fix NPE with returnFire field. #11729

merged 2 commits into from
Jul 5, 2023

Commits on Jul 4, 2023

  1. Fix NPE with returnFire field. 

    The field was marked as transient in two classes, meaning it would not be serialized and was null on deserialization, but the code did not handle it properly. Since the leaf code using it was marked with  `@RemoveOnNextMajorRelease` and could handle null, simply remove the non-null tag and propagate the deprecation tag.

Fixes triplea-game#11097.
    @asvitkine
    asvitkine committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    655d36d View commit details
    Browse the repository at this point in the history

  2. Formatting.

    @asvitkine
    asvitkine committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    2e68d39 View commit details
    Browse the repository at this point in the history