Fix NPE with returnFire field. #11729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field was marked as transient in two classes, meaning it would not be serialized and was null on deserialization, but the code did not handle it properly. Since the leaf code using it was marked with `@RemoveOnNextMajorRelease` and could handle null, simply remove the non-null tag and propagate the deprecation tag. Fixes triplea-game#11097.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary & Additional Notes
The field was marked as transient in two classes, meaning it would not be serialized and was null on deserialization, but the code did not handle it properly. Since the leaf code using it was marked with
@RemoveOnNextMajorReleaseand could handle null, simply remove the non-null tag and propagate the deprecation tag.Fixes #11097.
Issue was introduced by: #7497 (2.6 problem)
Release Note