Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Join Lobby #2801

Closed
ron-murhammer opened this issue Jan 3, 2018 · 4 comments
Closed

Can't Join Lobby #2801

ron-murhammer opened this issue Jan 3, 2018 · 4 comments
Labels
Problem A problem, bug, defect - something to fix Urgent Something in production is not working and is very noticable - urgent mitigation needed

Comments

@ron-murhammer
Copy link
Member

Get this error when trying to join lobby with 8230:

Failed while setting up logging
java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer;
	at games.strategy.net.nio.SocketWriteData.<init>(SocketWriteData.java:39)
	at games.strategy.net.nio.Encoder.write(Encoder.java:39)
	at games.strategy.net.nio.NioSocket.send(NioSocket.java:68)
	at games.strategy.net.nio.ClientQuarantineConversation.send(ClientQuarantineConversation.java:161)
	at games.strategy.net.nio.ClientQuarantineConversation.<init>(ClientQuarantineConversation.java:49)
	at games.strategy.net.ClientMessenger.<init>(ClientMessenger.java:98)
	at games.strategy.net.ClientMessenger.<init>(ClientMessenger.java:49)
	at games.strategy.engine.lobby.client.login.LobbyLogin.login(LobbyLogin.java:80)
@ron-murhammer ron-murhammer added Urgent Something in production is not working and is very noticable - urgent mitigation needed Problem A problem, bug, defect - something to fix labels Jan 3, 2018
@ron-murhammer
Copy link
Member Author

ron-murhammer commented Jan 3, 2018

The problem appears to be related to building with JDK9 while targeting and running on JDK8: plasma-umass/doppio#497

@ssoloff
Copy link
Member

ssoloff commented Jan 3, 2018

Confirmed I can't reproduce the issue when running from a Java 8 build.

I'll switch Travis to produce releases from the Java 8 build instead of the Java 9 build. Standby.

ssoloff added a commit to ssoloff/triplea-game-triplea that referenced this issue Jan 3, 2018
The Java 9 build seems to have some backwards incompatibilities when
targetting Java 8 (triplea-game#2801).
@ssoloff
Copy link
Member

ssoloff commented Jan 3, 2018

I believe the linked issue points out a defect in our Java 9 build setup (which, coincidentally, I now remember running into several years ago when trying to use JDK 7/8 to build for Java 6). Basically, we need to specify the -bootclasspath option pointing to a Java 8 runtime so the compiler uses the correct signatures.

The poster in the linked issue also raised awareness of a relatively new option (--release) that is supposed to handle what the three previously-required command line options did. It appears it simply standardizes the location of the alternate runtimes (and uses a stripped-down class file format to keep the size reasonable).

There's probably some issues that need to be worked out to achieve this in a straightforward way on both Travis and a dev's machine. I'll open a new issue for discussion.

@ssoloff
Copy link
Member

ssoloff commented Jan 3, 2018

Confirmed I can connect to the lobby using build 8233.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Problem A problem, bug, defect - something to fix Urgent Something in production is not working and is very noticable - urgent mitigation needed
Projects
None yet
Development

No branches or pull requests

2 participants