Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release from Java 8 build #2802

Merged

Conversation

ssoloff
Copy link
Member

@ssoloff ssoloff commented Jan 3, 2018

Fixes #2801.

The Java 9 build seems to have some backwards incompatibilities when targetting Java 8.

EDIT: Actually, the problem appears to be because we're not specifying a Java 8 boot classpath when using JDK 9 to build for Java 8.

The Java 9 build seems to have some backwards incompatibilities when
targetting Java 8 (triplea-game#2801).
@ron-murhammer
Copy link
Member

@ssoloff Correct, the issue is not specifying a Java 8 boot classpath which means we aren't guaranteed that the proper libraries are available at runtime when using Java 8. I'm gonna merge this to fix the latest release.

@ron-murhammer ron-murhammer merged commit 412c0b4 into triplea-game:master Jan 3, 2018
@codecov-io
Copy link

Codecov Report

Merging #2802 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2802   +/-   ##
=========================================
  Coverage     20.12%   20.12%           
  Complexity     5748     5748           
=========================================
  Files           815      815           
  Lines         73285    73285           
  Branches      12153    12153           
=========================================
  Hits          14750    14750           
  Misses        56428    56428           
  Partials       2107     2107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ed020...af1fedf. Read the comment docs.

@ssoloff ssoloff deleted the release-from-java-8-build branch January 3, 2018 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants