Skip to content

fix(blocks): only split paragraphs based on newlines #7573

fix(blocks): only split paragraphs based on newlines

fix(blocks): only split paragraphs based on newlines #7573

Triggered via pull request November 12, 2024 02:36
Status Success
Total duration 4m 19s
Artifacts

test.yml

on: pull_request
Install Dependencies
1m 7s
Install Dependencies
Matrix: E2E Test
Matrix: Unit Test
Build & Test
0s
Build & Test
Fit to window
Zoom out
Zoom in

Annotations

6 errors, 20 warnings, and 20 notices
link.spec.ts:394:1 › convert link to card: tests/link.spec.ts#L409
1) link.spec.ts:394:1 › convert link to card ───────────────────────────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toBeVisible() Locator: locator('.affine-link-popover') Expected: visible Received: <element(s) not found> Call log: - expect.toBeVisible with timeout 5000ms - waiting for locator('.affine-link-popover') 407 | await waitNextFrame(page); 408 | const linkPopoverLocator = page.locator('.affine-link-popover'); > 409 | await expect(linkPopoverLocator).toBeVisible(); | ^ 410 | const linkPopoverInput = page.locator('.affine-link-popover-input'); 411 | await expect(linkPopoverInput).toBeVisible(); 412 | await type(page, link); at /home/runner/work/blocksuite/blocksuite/tests/link.spec.ts:409:36
code/copy-paste.spec.ts:66:1 › drag copy paste: tests/code/copy-paste.spec.ts#L79
1) code/copy-paste.spec.ts:66:1 › drag copy paste ──────────────────────────────────────────────── Error: expect(received).toBe(expected) // Object.is equality Expected: "useuse" Received: "1234use" 77 | 78 | const content = await getInlineSelectionText(page); > 79 | expect(content).toBe('useuse'); | ^ 80 | 81 | await assertRichTextInlineRange(page, 0, 3, 0); 82 | }); at /home/runner/work/blocksuite/blocksuite/tests/code/copy-paste.spec.ts:79:19
paragraph.spec.ts:228:1 › insert new paragraph block by enter: tests/utils/asserts.ts#L209
1) paragraph.spec.ts:228:1 › insert new paragraph block by enter ───────────────────────────────── Error: expect(received).toEqual(expected) // deep equality - Expected - 2 + Received + 2 Array [ "", - "", - "", + " + ", ] at utils/asserts.ts:209 207 | }); 208 | }, currentEditorIndex); > 209 | expect(actualTexts).toEqual(texts); | ^ 210 | } 211 | 212 | export async function assertEdgelessCanvasText(page: Page, text: string) { at assertRichTexts (/home/runner/work/blocksuite/blocksuite/tests/utils/asserts.ts:209:23) at /home/runner/work/blocksuite/blocksuite/tests/paragraph.spec.ts:234:3
hotkey/multiline.spec.ts:100:1 › should cut work multiple line: tests/hotkey/multiline.spec.ts#L110
1) hotkey/multiline.spec.ts:100:1 › should cut work multiple line ──────────────────────────────── Error: Snapshot comparison failed: { "type": "block", "id": "0", "flavour": "affine:page", "version": 2, "props": { "title": { "$blocksuite:internal:text$": true, "delta": [] } }, "children": [ { "type": "block", "id": "1", "flavour": "affine:note", "version": 1, "props": { "xywh": "[0,0,498,92]", "background": "--affine-note-background-white", "index": "a0", "hidden": false, "displayMode": "both", "edgeless": { "style": { "borderRadius": 8, "borderSize": 4, "borderStyle": "none", "shadowType": "--affine-note-shadow-box" } } }, "children": [ { "type": "block", "id": "2", "flavour": "affine:paragraph", "version": 1, "props": { "type": "text", "text": { "$blocksuite:internal:text$": true, "delta": [ { "insert": "123" } ] } }, "children": [] }, { "type": "block", "id": "3", "flavour": "affine:paragraph", "version": 1, "props": { "type": "text", "text": { "$blocksuite:internal:text$": true, "delta": [ { "insert": "456" } ] } }, "children": [] }, { "type": "block", "id": "4", "flavour": "affine:paragraph", "version": 1, "props": { "type": "text", "text": { "$blocksuite:internal:text$": true, "delta": [ { "insert": "789" } ] } }, "children": [] } ] } ] } Expected: /home/runner/work/blocksuite/blocksuite/tests/snapshots/hotkey/multiline.spec.ts/should-cut-work-multiple-line-init.json Received: /home/runner/work/blocksuite/blocksuite/tests/test-results/hotkey-multiline-should-cut-work-multiple-line/should-cut-work-multiple-line-init-actual.json 108 | // cut 109 | await page.keyboard.press(`${SHORT_KEY}+x`); > 110 | expect(await getPageSnapshot(page, true)).toMatchSnapshot( | ^ 111 | `${testInfo.title}_init.json` 112 | ); 113 | await undoByKeyboard(page); at /home/runner/work/blocksuite/blocksuite/tests/hotkey/multiline.spec.ts:110:45
edgeless/shortcut.spec.ts:119:1 › should not switch shapes in editing: tests/utils/actions/edgeless.ts#L357
1) edgeless/shortcut.spec.ts:119:1 › should not switch shapes in editing ───────────────────────── TimeoutError: locator.click: Timeout 5000ms exceeded. Call log: - waiting for locator('edgeless-slide-menu edgeless-tool-icon-button').filter({ hasText: 'Square' }) - locator resolved to <edgeless-tool-icon-button role="button">…</edgeless-tool-icon-button> - attempting click action - waiting for element to be visible, enabled and stable - element is not stable - retrying click action, attempt #1 - waiting for element to be visible, enabled and stable - element is not stable - retrying click action, attempt #2 - waiting 20ms - waiting for element to be visible, enabled and stable - element was detached from the DOM, retrying at utils/actions/edgeless.ts:357 355 | .locator('edgeless-slide-menu edgeless-tool-icon-button') 356 | .filter({ hasText: shape }); > 357 | await squareShapeButton.click(); | ^ 358 | break; 359 | } 360 | } at setEdgelessTool (/home/runner/work/blocksuite/blocksuite/tests/utils/actions/edgeless.ts:357:31) at /home/runner/work/blocksuite/blocksuite/tests/edgeless/shortcut.spec.ts:137:3
edgeless/note/drag-handle.spec.ts:122:1 › drag handle should work across multiple notes: tests/edgeless/note/drag-handle.spec.ts#L141
1) edgeless/note/drag-handle.spec.ts:122:1 › drag handle should work across multiple notes ─────── Error: Timed out 5000ms waiting for expect(locator).toBeHidden() Locator: locator('.affine-drag-handle-container') Expected: hidden Received: visible Call log: - expect.toBeHidden with timeout 5000ms - waiting for locator('.affine-drag-handle-container') - locator resolved to <div draggable="true" class="affine-drag-handle-container">…</div> - unexpected value "visible" - locator resolved to <div draggable="true" class="affine-drag-handle-container">…</div> - unexpected value "visible" - locator resolved to <div draggable="true" class="affine-drag-handle-container">…</div> - unexpected value "visible" - locator resolved to <div draggable="true" class="affine-drag-handle-container">…</div> - unexpected value "visible" - locator resolved to <div draggable="true" class="affine-drag-handle-container">…</div> - unexpected value "visible" - locator resolved to <div draggable="true" class="affine-drag-handle-container">…</div> - unexpected value "visible" - locator resolved to <div draggable="true" class="affine-drag-handle-container">…</div> - unexpected value "visible" - locator resolved to <div draggable="true" class="affine-drag-handle-container">…</div> - unexpected value "visible" - locator resolved to <div draggable="true" class="affine-drag-handle-container">…</div> - unexpected value "visible" 139 | await page.mouse.dblclick(CENTER_X, CENTER_Y - 20); 140 | await dragHandleFromBlockToBlockBottomById(page, '3', '7'); > 141 | await expect(page.locator('.affine-drag-handle-container')).toBeHidden(); | ^ 142 | await waitNextFrame(page); 143 | await assertRichTexts(page, ['456', '789', '000', '123']); 144 | at /home/runner/work/blocksuite/blocksuite/tests/edgeless/note/drag-handle.spec.ts:141:63
E2E Test (16)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (2)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (20)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (3)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (19)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (17)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (15)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (18)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (1)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (4)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (14)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (10)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (13)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (12)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (6)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (9)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (5)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (11)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (7)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
E2E Test (8)
Codecov: Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
🎭 Playwright Run Summary
1 flaky link.spec.ts:394:1 › convert link to card ────────────────────────────────────────────────────── 1 skipped 45 passed (47.1s)
🎭 Playwright Run Summary
1 flaky code/copy-paste.spec.ts:66:1 › drag copy paste ───────────────────────────────────────────────── 1 skipped 46 passed (47.5s)
🎭 Playwright Run Summary
3 skipped 44 passed (40.5s)
🎭 Playwright Run Summary
4 skipped 43 passed (52.4s)
🎭 Playwright Run Summary
47 passed (54.6s)
🎭 Playwright Run Summary
1 flaky paragraph.spec.ts:228:1 › insert new paragraph block by enter ────────────────────────────────── 46 passed (48.2s)
🎭 Playwright Run Summary
1 skipped 46 passed (55.7s)
🎭 Playwright Run Summary
47 passed (56.0s)
🎭 Playwright Run Summary
2 skipped 46 passed (54.5s)
🎭 Playwright Run Summary
47 passed (59.4s)
🎭 Playwright Run Summary
1 flaky hotkey/multiline.spec.ts:100:1 › should cut work multiple line ───────────────────────────────── 46 passed (1.0m)
🎭 Playwright Run Summary
1 skipped 46 passed (1.1m)
🎭 Playwright Run Summary
47 passed (1.1m)
🎭 Playwright Run Summary
1 flaky edgeless/shortcut.spec.ts:119:1 › should not switch shapes in editing ────────────────────────── 2 skipped 44 passed (1.1m)
🎭 Playwright Run Summary
47 passed (1.3m)
🎭 Playwright Run Summary
1 flaky edgeless/note/drag-handle.spec.ts:122:1 › drag handle should work across multiple notes ──────── 10 skipped 36 passed (1.5m)
🎭 Playwright Run Summary
6 skipped 41 passed (1.4m)
🎭 Playwright Run Summary
1 skipped 46 passed (1.6m)
🎭 Playwright Run Summary
1 skipped 46 passed (1.6m)
🎭 Playwright Run Summary
47 passed (1.7m)