Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blocks): only split paragraphs based on newlines #8702

Merged

Conversation

fourdim
Copy link
Contributor

@fourdim fourdim commented Nov 7, 2024

This closes #8679

Copy link

changeset-bot bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: 353fdc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Nov 7, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fourdim commented Nov 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fourdim and the rest of your teammates on Graphite Graphite

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 2:37am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 2:37am

@fourdim fourdim marked this pull request as ready for review November 7, 2024 15:10
@fourdim fourdim requested a review from a team as a code owner November 7, 2024 15:10
Copy link

nx-cloud bot commented Nov 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 353fdc0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.07 MB (+0.05% 🔺)
@blocksuite/affine/block-std 156.62 KB (0%)
@blocksuite/affine/block-std/gfx 80.41 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.8 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.6 KB (0%)
@blocksuite/affine/inline 32.04 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.87 MB (+0.01% 🔺)
@blocksuite/affine/blocks 1.96 MB (+0.02% 🔺)
@blocksuite/affine/blocks/schemas 88.86 KB (0%)

@fourdim fourdim force-pushed the 11-07-fix_blocks_only_split_paragraphs_based_on_newlines branch from f73f273 to 1ddae3d Compare November 7, 2024 16:09
@fourdim fourdim marked this pull request as draft November 7, 2024 16:15
@fourdim fourdim force-pushed the 11-07-fix_blocks_only_split_paragraphs_based_on_newlines branch from 1ddae3d to 1e83be3 Compare November 7, 2024 16:19
@fourdim fourdim force-pushed the 11-07-fix_blocks_only_split_paragraphs_based_on_newlines branch from 1e83be3 to fedff13 Compare November 8, 2024 00:31
@fourdim fourdim marked this pull request as ready for review November 8, 2024 00:37
@fourdim fourdim added the merge label Nov 12, 2024
Copy link
Contributor Author

fourdim commented Nov 12, 2024

Merge activity

  • Nov 11, 9:35 PM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 11, 9:35 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 11, 9:41 PM EST: A user merged this pull request with the Graphite merge queue.

@fourdim fourdim force-pushed the 11-07-fix_blocks_only_split_paragraphs_based_on_newlines branch from fedff13 to 353fdc0 Compare November 12, 2024 02:36
@graphite-app graphite-app bot merged commit 353fdc0 into master Nov 12, 2024
36 checks passed
@graphite-app graphite-app bot deleted the 11-07-fix_blocks_only_split_paragraphs_based_on_newlines branch November 12, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Copying a table and pasting it into the editor no longer works
3 participants