feat(ios): initialize appsflyer #8951
+151
−43
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -123,6 +123,10 @@ jobs: | |
| enableScripts: false | ||
| - name: Cap sync | ||
| run: yarn workspace @affine/ios cap sync | ||
| - name: Write afdevkey | ||
| working-directory: packages/frontend/apps/ios/App | ||
| run: | | ||
| echo "${{ env.APPSFLYER_DEV_KEY }}" | base64 --decode -o App/afdevkey.plist | ||
|
Comment on lines
+126
to
+129
There was a problem hiding this comment. Add error checking and validation for the APPSFLYER_DEV_KEY environment variable. Consider: 1) Checking if env var exists before attempting decode, 2) Validating decoded content is valid plist format, 3) Adding conditional to skip if not configured. Example: if [ -n "$APPSFLYER_DEV_KEY" ]; then echo "$APPSFLYER_DEV_KEY" | base64 --decode > App/afdevkey.plist || exit 1; fi Spotted by Graphite Reviewer (based on CI logs) |
||
| - name: Signing By Apple Developer ID | ||
| uses: apple-actions/import-codesign-certs@v3 | ||
| id: import-codesign-certs | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,3 +17,5 @@ App/**/*.p8 | |
| *.zip | ||
| *.cer | ||
| App/fastlane/report.xml | ||
|
|
||
| afdevkey.plist | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,49 +1,112 @@ | ||
| import UIKit | ||
| import Capacitor | ||
| import AppsFlyerLib | ||
| import AppTrackingTransparency | ||
|
|
||
| @UIApplicationMain | ||
| class AppDelegate: UIResponder, UIApplicationDelegate, AppsFlyerLibDelegate, DeepLinkDelegate { | ||
| func onConversionDataSuccess(_ conversionInfo: [AnyHashable : Any]) { | ||
| print("onConversionDataSuccess: \(conversionInfo)") | ||
| } | ||
|
|
||
| func onConversionDataFail(_ error: any Error) { | ||
| print("onConversionDataFail: \(error)") | ||
| } | ||
|
|
||
|
|
||
| var window: UIWindow? | ||
| var appFlyerReady = false | ||
|
|
||
| func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool { | ||
|
|
||
| // Get AppsFlyer preferences from .plist file | ||
| guard let propertiesPath = Bundle.main.path(forResource: "afdevkey", ofType: "plist"), | ||
| let properties = NSDictionary(contentsOfFile: propertiesPath) as? [String:String] else { | ||
| print("WARNING: Cannot find `afdevkey`") | ||
| return true | ||
| } | ||
| guard let appsFlyerDevKey = properties["appsFlyerDevKey"], | ||
| let appleAppID = properties["appleAppID"] else { | ||
| print("WARNING: Cannot find `appsFlyerDevKey` or `appleAppID` key") | ||
| return true | ||
| } | ||
|
|
||
| if appsFlyerDevKey.isEmpty || appleAppID.isEmpty { | ||
| return true | ||
| } | ||
|
|
||
| self.appFlyerReady = true | ||
|
|
||
| AppsFlyerLib.shared().isDebug = true | ||
|
|
||
| AppsFlyerLib.shared().appsFlyerDevKey = appsFlyerDevKey | ||
| AppsFlyerLib.shared().appleAppID = appleAppID | ||
|
|
||
| AppsFlyerLib.shared().waitForATTUserAuthorization(timeoutInterval: 60) | ||
|
|
||
| AppsFlyerLib.shared().delegate = self | ||
| AppsFlyerLib.shared().deepLinkDelegate = self | ||
|
|
||
| print("Appflyer is ready") | ||
|
|
||
| return true | ||
| } | ||
|
|
||
| func applicationWillResignActive(_ application: UIApplication) { | ||
| // Sent when the application is about to move from active to inactive state. This can occur for certain types of temporary interruptions (such as an incoming phone call or SMS message) or when the user quits the application and it begins the transition to the background state. | ||
| // Use this method to pause ongoing tasks, disable timers, and invalidate graphics rendering callbacks. Games should use this method to pause the game. | ||
| } | ||
|
|
||
| func applicationDidEnterBackground(_ application: UIApplication) { | ||
| // Use this method to release shared resources, save user data, invalidate timers, and store enough application state information to restore your application to its current state in case it is terminated later. | ||
| // If your application supports background execution, this method is called instead of applicationWillTerminate: when the user quits. | ||
| } | ||
|
|
||
| func applicationWillEnterForeground(_ application: UIApplication) { | ||
| // Called as part of the transition from the background to the active state; here you can undo many of the changes made on entering the background. | ||
| } | ||
|
|
||
| func applicationDidBecomeActive(_ application: UIApplication) { | ||
| // Restart any tasks that were paused (or not yet started) while the application was inactive. If the application was previously in the background, optionally refresh the user interface. | ||
|
|
||
| // if self.appFlyerReady { | ||
| // AppsFlyerLib.shared().start() | ||
| // if #available(iOS 14, *) { | ||
| // ATTrackingManager.requestTrackingAuthorization { (status) in | ||
| // switch status { | ||
| // case .denied: | ||
| // print("AuthorizationStatus is denied") | ||
| // case .notDetermined: | ||
| // print("AuthorizationStatus is notDetermined") | ||
| // case .restricted: | ||
| // print("AuthorizationStatus is restricted") | ||
| // case .authorized: | ||
| // print("AuthorizationStatus is authorized") | ||
| // @unknown default: | ||
| // fatalError("Invalid authorization status") | ||
| // } | ||
| // } | ||
| // } | ||
| // } | ||
| } | ||
|
|
||
| func applicationWillTerminate(_ application: UIApplication) { | ||
| // Called when the application is about to terminate. Save data if appropriate. See also applicationDidEnterBackground:. | ||
| } | ||
|
|
||
| func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey: Any] = [:]) -> Bool { | ||
| // Called when the app was launched with a url. Feel free to add additional processing here, | ||
| // but if you want the App API to support tracking app url opens, make sure to keep this call | ||
| if self.appFlyerReady { | ||
| AppsFlyerLib.shared().handleOpen(url, options: options) | ||
| } | ||
| return ApplicationDelegateProxy.shared.application(app, open: url, options: options) | ||
| } | ||
|
|
||
| func application(_ application: UIApplication, continue userActivity: NSUserActivity, restorationHandler: @escaping ([UIUserActivityRestoring]?) -> Void) -> Bool { | ||
| // Called when the app was launched with an activity, including Universal Links. | ||
| // Feel free to add additional processing here, but if you want the App API to support | ||
| // tracking app url opens, make sure to keep this call | ||
| return ApplicationDelegateProxy.shared.application(application, continue: userActivity, restorationHandler: restorationHandler) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>appsFlyerDevKey</key> | ||
| <string></string> | ||
| <key>appleAppID</key> | ||
| <string></string> | ||
| </dict> | ||
| </plist> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path should be
afdevkey.plistsince theworking-directorydirective has already placed execution context in theAppdirectory. The current pathApp/afdevkey.plistwill attempt to write to a non-existent nested directory.Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.