feat(ios): initialize appsflyer #8951
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0d7072d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #8951 +/- ##
==========================================
- Coverage 64.74% 64.69% -0.06%
==========================================
Files 664 664
Lines 37338 37338
Branches 3607 3607
==========================================
- Hits 24176 24156 -20
- Misses 12795 12815 +20
Partials 367 367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CatsJuice
force-pushed
the
catsjuice/feat/appsflyer
branch
from
b87a9c4 to
92ffd0c
Compare
CatsJuice
force-pushed
the
catsjuice/feat/appsflyer
branch
from
92ffd0c to
b658791
Compare
CatsJuice
force-pushed
the
catsjuice/feat/appsflyer
branch
from
b658791 to
0d7072d
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| - name: Write afdevkey | ||
| working-directory: packages/frontend/apps/ios/App | ||
| run: | | ||
| echo "${{ env.APPSFLYER_DEV_KEY }}" | base64 --decode -o App/afdevkey.plist |
There was a problem hiding this comment.
The path should be afdevkey.plist since the working-directory directive has already placed execution context in the App directory. The current path App/afdevkey.plist will attempt to write to a non-existent nested directory.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
| - name: Write afdevkey | ||
| working-directory: packages/frontend/apps/ios/App | ||
| run: | | ||
| echo "${{ env.APPSFLYER_DEV_KEY }}" | base64 --decode -o App/afdevkey.plist |
There was a problem hiding this comment.
Add error checking and validation for the APPSFLYER_DEV_KEY environment variable. Consider: 1) Checking if env var exists before attempting decode, 2) Validating decoded content is valid plist format, 3) Adding conditional to skip if not configured. Example: if [ -n "$APPSFLYER_DEV_KEY" ]; then echo "$APPSFLYER_DEV_KEY" | base64 --decode > App/afdevkey.plist || exit 1; fi
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
close AF-1740