feat(object_lanelet_filter): add velocity direction based object lanelet filter #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…let filter (autowarefoundation#7107) * chore: refactor lanelet filter function Signed-off-by: yoshiri <[email protected]> * feat: add lanelet direction filter Signed-off-by: yoshiri <[email protected]> * fix: do not change default settings Signed-off-by: yoshiri <[email protected]> * feat: skip orientation unavailable objects Signed-off-by: yoshiri <[email protected]> * fix: feature variable name Signed-off-by: yoshiri <[email protected]> --------- Signed-off-by: yoshiri <[email protected]>
…lanelet filter (autowarefoundation#5324) * fix(detected_object_validation): consider shoulder lanelet in object lanelet filter Signed-off-by: Shumpei Wakabayashi <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: Shumpei Wakabayashi <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: yoshiri <[email protected]>
|
@saka1-s 私の手元では動作確認できていますが、今一度時間があるときにsakaiさんの方でも確認していただけると助かります 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
小松でRadar誤検知により急停止する課題の対処PRです。
Fix radar reverted issue in autowarefoundation#7107 and cherry-pick it.
JIRA ticket is: https://tier4.atlassian.net/browse/RT0-31022?atlOrigin=eyJpIjoiZWU0YjUyZmYxYjNiNGVmZWJlNTg1MWIyNmM0YWMzOGQiLCJwIjoiaiJ9
Related links
入れる対象が古いため、未導入の変更は下記多岐に渡りますが、今回の機能で必要な最初と最後だけをcherry-pickしました。
Tests performed
@saka1-s Could you test this PR?
launch PR is here.
Notes for reviewers
Interface changes
ROS Topic Changes
ROS Parameter Changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.