Skip to content

Commit

Permalink
refactor: remove expo-notifications which requires expo-application
Browse files Browse the repository at this point in the history
  • Loading branch information
linonetwo committed Dec 1, 2024
1 parent 2ebeaab commit bca770c
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 102 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/build-aab.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ jobs:
- name: Install dependencies
run: pnpm install
- name: Initialize and Update Submodules
run: pnpm run init-submodules
- name: Fix gradle error
run: pnpm exec zx scripts/fix-gradle.mjs

Expand All @@ -94,10 +92,6 @@ jobs:
pnpm exec expo prebuild -p android --clean
pnpm exec zx scripts/removeDebugSigningConfigs.mjs
# TODO: https://github.com/tiddly-gittly/TidGi-Mobile/issues/6
# - name: Remove prorietary bits (for fix f-droid)
# run: npx zx scripts/fit-f-droid.mjs

- name: Build AAB
run: |
cd android
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/build-apk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ jobs:
- name: Install dependencies
run: pnpm install
- name: Initialize and Update Submodules
run: pnpm run init-submodules
- name: Fix gradle error
run: pnpm exec zx scripts/fix-gradle.mjs

Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"expo-haptics": "14.0.0",
"expo-linking": "~7.0.3",
"expo-localization": "16.0.0",
"expo-notifications": "0.29.8",
"expo-share-intent": "^3.0.0",
"expo-sharing": "13.0.0",
"expo-sqlite": "15.0.3",
Expand Down
93 changes: 0 additions & 93 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/pages/WikiWebView/useWikiWebViewNotification.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/**
* expo-notifications is not installed to prevent install expo-application which has proprietary code.
*/
/* eslint-disable @typescript-eslint/strict-boolean-expressions */
/* eslint-disable unicorn/no-null */
/* eslint-disable @typescript-eslint/require-await */
Expand Down

0 comments on commit bca770c

Please sign in to comment.