Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple improvements and updates #597

Closed
wants to merge 1 commit into from

Conversation

gssbzn
Copy link

@gssbzn gssbzn commented Aug 17, 2021

Removes obsolete brew hacks and moves asdf to a homebrew installation

@cpytel
Copy link
Member

cpytel commented Mar 28, 2022

This would close #563

@cpytel
Copy link
Member

cpytel commented Mar 29, 2022

Thanks for this. In my testing on a fresh install of macOS, I found that removing the addition of homebrew to the path caused the rest of the script to fail because, well, it was not in the path.

I'm going to close this in favor of #602

@cpytel cpytel closed this Mar 29, 2022
@cpytel
Copy link
Member

cpytel commented Mar 29, 2022

Oh, I should have also said, I plan to look at separately switching asdf to the homebrew version, but feel free to open a PR that makes just that change. Thanks again.

cpytel added a commit that referenced this pull request Mar 31, 2022
Closes #563 
Closes #587
Closes #600

This makes the following changes:

* Installs asdf via Homebrew, thanks @jdbann in #592 and @gssbzn in #597
* The latest version of the asdf nodejs plugin takes care of the keyring stuff itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants