Fix scope on device code grant #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 30, 2024
|
@hafezdivandari sorry for the radio silence. I will aim to look at the PRs this week |
|
Thank you @Sephster |
|
Sorry I've had an emergency in my work I've been dealing with since Thursday. Will get on this as soon as complete |
Sephster
requested changes
Oct 27, 2024
Co-authored-by: Andrew Millington <[email protected]>
hafezdivandari
changed the title
formatting formatting simplify tests revert example changes formatting fix style fix sa encrypt device code Revert "no encryption on this grant" This reverts commit 7522a46.
hafezdivandari
force-pushed
the
master-fix-scope
branch
from
e3e7ca4
to
c9639be
Compare
This reverts commit c9639be.
hafezdivandari
changed the title
Sephster
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scopeparameter has been mistakenly required on device access token request #1411scopeparameter and section 3.4 doesn't expectscopeparameter.Encrypt / decrypt the device code.