Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New major version required for league/oauth2-server 9 #1748

Closed
TomHAnderson opened this issue May 30, 2024 · 11 comments
Closed

New major version required for league/oauth2-server 9 #1748

TomHAnderson opened this issue May 30, 2024 · 11 comments

Comments

@TomHAnderson
Copy link

I'm sure other people have reasons to see the upgrade too. Here's mine:

league/oauth2-server 8.x uses league/event 2.2 but league/event 3.0.x has been out for some time. My library https://doctrine-orm-graphql.apiskeletons.dev/en/latest/ had to degrade from 3.0.x to 2.2 as a new major version because https://ldog.apiskeletons.dev/ needs an OAuth2 library and since the LDOG Stack is rooted in Laravel, you folks have the best thing going.

To keep this library as relevant as ever, I'm requesting you begin work for support of league/oauth2-server 9

@Sephster
Copy link
Contributor

There is an open bug in v9 which I'm hoping to fix early next week. It would be best to get this into passport before a new major is tagged

@driesvints
Copy link
Member

Hey @TomHAnderson! We have a fully working version ready to go on the 13.x branch which is pending release. But before we do that there's a couple of things we still want to address. @hafezdivandari is looking into this. A few PR's are still pending a review from Taylor which atm also has quite a few other things going on. I'm also hoping we can release a new major version soon but for now we'll have to have a bit more patience.

@Sephster that's cool. Feel free to ping me here when that's done. Thanks for all your work on oauth server 🙏

@hafezdivandari
Copy link
Contributor

Hi @Sephster, I was wondering if you had any availability to review these 2 PRs I've sent?

@saade
Copy link

saade commented Jun 18, 2024

Sad to not see Token Introspection in v9 :(

@driesvints
Copy link
Member

@saade what do you mean?

@saade
Copy link

saade commented Jun 18, 2024

@driesvints

#575 #491

@driesvints
Copy link
Member

@saade as said in those issues, we need OAuth Server to implement this first before we can implement it in Passport. Maybe that's already done? @Sephster

@saade
Copy link

saade commented Jun 18, 2024

Yup, commented on those issues as well, just replied here as @Sephster was aware of this PR :)

@Sephster
Copy link
Contributor

Token introspection isn't in v9. No concrete plans on it yet. Working on fixing bugs raised by @hafezdivandari first and will post here when completed. Thanks

@driesvints
Copy link
Member

Going to close this one now. We'll get a new major version out as soon as we're done with all the needed changes. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants