Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception message is hidden #398

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Exception message is hidden #398

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a00346
Update Server.php
AidasK Jun 25, 2024
952731f
Update Server.php
AidasK Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Server.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ public function makeImage($path, array $params)
$this->api->run($tmp, $this->getAllParams($params))
);
} catch (FilesystemV2Exception $exception) {
throw new FilesystemException('Could not write the image `'.$cachedPath.'`.');
throw new FilesystemException('Could not write the image `'.$cachedPath.'`. ' . $exception->getMessage());
Copy link

@Art4 Art4 Jun 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not directly inserting the catched exception?

Suggested change
throw new FilesystemException('Could not write the image `'.$cachedPath.'`. ' . $exception->getMessage());
throw new FilesystemException('Could not write the image `'.$cachedPath.'`. '.$exception->getMessage(), 0, $exception);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, updated!

} finally {
unlink($tmp);
}
Expand Down
Loading