Exception message is hidden #398

AidasK · 2024-06-25T10:21:48Z

It took too long to find a cause of a not working cache setup. The real issue was wrong bucket setup:

Unable to write file at location: a. {
  "error": {
    "code": 400,
    "message": "Cannot insert legacy ACL for an object when uniform bucket-level access is enabled. Read more at https://cloud.google.com/storage/docs/uniform-bucket-level-access",
    "errors": [
      {
        "message": "Cannot insert legacy ACL for an object when uniform bucket-level access is enabled. Read more at https://cloud.google.com/storage/docs/uniform-bucket-level-access",
        "domain": "global",
        "reason": "invalid"
      }
    ]
  }
}.

So exceptions should not be hidden as they do help to solve the problem easier.

mantasekom · 2024-06-25T10:31:10Z

It would be really nice to have this fix.

Art4 · 2024-06-25T10:43:59Z

src/Server.php

@@ -689,7 +689,7 @@ public function makeImage($path, array $params)
                $this->api->run($tmp, $this->getAllParams($params))
            );
        } catch (FilesystemV2Exception $exception) {
-            throw new FilesystemException('Could not write the image `'.$cachedPath.'`.');
+            throw new FilesystemException('Could not write the image `'.$cachedPath.'`. ' . $exception->getMessage());


Why not directly inserting the catched exception?

Suggested change

throw new FilesystemException('Could not write the image `'.$cachedPath.'`. ' . $exception->getMessage());

throw new FilesystemException('Could not write the image `'.$cachedPath.'`. '.$exception->getMessage(), 0, $exception);

Makes sense, updated!

Update Server.php

9a00346

Art4 reviewed Jun 25, 2024

View reviewed changes

Update Server.php

952731f

ADmad merged commit e9c5eba into thephpleague:master Jun 25, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exception message is hidden #398

Exception message is hidden #398

AidasK commented Jun 25, 2024

mantasekom commented Jun 25, 2024

Art4 Jun 25, 2024 •

edited

Loading

AidasK Jun 25, 2024

	throw new FilesystemException('Could not write the image `'.$cachedPath.'`. ' . $exception->getMessage());
	throw new FilesystemException('Could not write the image `'.$cachedPath.'`. '.$exception->getMessage(), 0, $exception);

Exception message is hidden #398

Exception message is hidden #398

Conversation

AidasK commented Jun 25, 2024

mantasekom commented Jun 25, 2024

Art4 Jun 25, 2024 • edited Loading

Choose a reason for hiding this comment

AidasK Jun 25, 2024

Choose a reason for hiding this comment

Art4 Jun 25, 2024 •

edited

Loading