Uses jq to parse json output from Bing.com

README.md

@@ -8,7 +8,7 @@ it to a directory.
 
 The script was tested on:
 
-- Mac OS X 10.8 - 10.12
+- Mac OS X 10.8 - 10.12, 10.15
 - Ubuntu 12.04 - 16.04
 - Arch 2022.01.01
 
@@ -43,6 +43,9 @@ Options:
   -h --help                      Show this screen.
   --version                      Show version.
 ```
+Dependencies
+------------
+The script uses [jq](https://stedolan.github.io/jq/) to parse json output from Bing.com. Installation instructions can be found on [jq's download page](https://stedolan.github.io/jq/download/).
 
 Configuration on Mac
 --------------------

Tools/com.ideasftw.bing-wallpaper.plist

@@ -8,7 +8,14 @@
 		<array>
 			<string>/bin/bash</string>
 			<string>/Users/username/Pictures/bing-wallpaper.sh</string>
+			<string>-s</string>
+			<string>-w</string>
 		</array>
+		<key>EnvironmentVariables</key>
+		<dict>
+			<key>PATH</key>
+			<string>/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin</string>
+		</dict>
 		<key>LowPriorityIO</key>
 		<true/>
 		<key>Nice</key>
@@ -20,5 +27,9 @@
 			<key>Minute</key>
 			<integer>0</integer>
 		</dict>
+		<key>StandardErrorPath</key>
+		<string>/tmp/bing-wallpaper.err</string>
+		<key>StandardOutPath</key>
+		<string>/tmp/bing-wallpaper.out</string>
 	</dict>
 </plist>

bing-wallpaper.sh

@@ -42,11 +42,11 @@ print_message() {
 }
 
 # Defaults
-PICTURE_DIR="$HOME/Pictures/bing-wallpapers/"
-RESOLUTION="1920x1080"
+PICTURE_DIR="$HOME/Pictures/bing-wallpapers"
+RESOLUTION="UHD"
+BOOST=1
 
 # Option parsing
-BOOST=1
 while [[ $# -gt 0 ]]; do
     key="$1"
 
@@ -96,38 +96,43 @@ while [[ $# -gt 0 ]]; do
     shift
 done
 
+# Test for existence of the command jq
+if ! command -v jq &> /dev/null
+then
+    echo "The command jq could not be found. Refer to the readme for how to install jq."
+    exit
+fi
+
 # Set options
 [ -n "$QUIET" ] && CURL_QUIET='-s'
 [ -n "$SSL" ]   && PROTO='https'   || PROTO='http'
 
 # Create picture directory if it doesn't already exist
 mkdir -p "${PICTURE_DIR}"
 
+# Parse bing.com and acquire picture URL(s)
 read -ra urls < <(curl -sL "$PROTO://www.bing.com/HPImageArchive.aspx?format=js&n=$BOOST" | \
-    # Extract the image urls from the JSON response
-    grep -Po '(?<=url":").*?(?=")' | \
-    # Set the image resolution
+    jq -r '.images | reverse | .[] | .url' | \
     sed -e "s/[[:digit:]]\{1,\}x[[:digit:]]\{1,\}/$RESOLUTION/" | \
-    # FQDN the image urls
-    sed -e "s/\(.*\)/${PROTO}\:\/\/www.bing.com\1/" | \
-    tr "\n" " ")
+    sed -e "s/\(.*\)/$PROTO:\/\/bing.com\1/")
 
-for pic in "${urls[@]}"; do
+for p in "${urls[@]}"; do
     if [ -z "$FILENAME" ]; then
-        filename=$(echo "$pic" | sed -e 's/.*[?&;]id=\([^&]*\).*/\1/' | grep -oe '[^\.]*\.[^\.]*$')
+        filename=$(echo "$p" | sed -e 's/.*[?&;]id=\([^&]*\).*/\1/' | grep -oe '[^\.]*\.[^\.]*$')
     else
         filename="$FILENAME"
     fi
     if [ -n "$FORCE" ] || [ ! -f "$PICTURE_DIR/$filename" ]; then
-        print_message "Downloading: $filename..."
-        curl $CURL_QUIET -Lo "$PICTURE_DIR/$filename" "$pic"
+        print_message "Downloading: $filename from $p..."
+        curl $CURL_QUIET -Lo "$PICTURE_DIR/$filename" "$p"
     else
         print_message "Skipping: $filename..."
     fi
 done
 
 if [ -n "$SET_WALLPAPER" ]; then
+    print_message "Setting wallpaper to $PICTURE_DIR/$filename"
     /usr/bin/osascript<<END
-tell application "System Events" to set picture of every desktop to ("$PICTURE_DIR/$filename" as POSIX file as alias)
+tell application "System Events" to tell every desktop to set picture to "$PICTURE_DIR/$filename"
 END
 fi