Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses jq to parse json output from Bing.com #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Lyncredible
Copy link

This commit makes the script compatible with current Bing.com as of 2020-12-21
and macOS 10.15. It includes the following changes:

  • Use jq to parse json output from Bing.com
  • Merge the latest and boost code paths
  • Change wallpaper on macOS 10.15 with proper applescript
  • Use https for all Bing.com requests if -s/--ssl is specified

Backward compatibility is not tested with older macOS versions.

thejandroman added a commit that referenced this pull request Jan 18, 2022
After moving to Arch I decided to give this forgotten script a try. It didn't work. It was also very complicated. URL parsing from JSON is a crazy thing to try to do in a bash script. I don't have a Mac to test these changes on but hopefully everything still works. There were a number of overlapping PRs over the years that made it into this revision. I've tried to add credit to the original PRs where applicable.

Summary of changes:

1. Merge latest and boost code paths (From @Lyncredible in #39)
2. Use https for all requests if -s (From @Lyncredible in #39)
3. Update URL patterns  (From @Lyncredible in #39, @microdog in #36, @nitrogear in #23)
4. Add UHD support (fixes #43)
5. Remove contributing.json as it wasn't used anymore
@thejandroman thejandroman mentioned this pull request Jan 18, 2022
This commit makes the script compatible with current Bing.com as of 2020-12-21
and macOS 10.15. It includes the following changes:

- Use jq to parse json output from Bing.com
- Merge the latest and boost code paths
- Change wallpaper on macOS 10.15 with proper applescript
- Use https for all Bing.com requests if `-s/--ssl` is specified

Backward compatibility is _not_ tested with older macOS versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant