Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Ruby 2.7 tests use dedicated bundler version #391

Merged
merged 1 commit into from
Dec 15, 2023
Merged

For Ruby 2.7 tests use dedicated bundler version #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions theforeman.org/pipelines/lib/rvm.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ def gemset(name = null) {

def configureRVM(ruby, name = '', bundler_version = null) {
emptyGemset(ruby, name)

if (ruby == '2.7') {
bundler_version = '2.4.22'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be < 2.5 to allow 2.4.z patches?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. But since you are asking, I am assuming maybe yes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

I have no idea how high the chances of a 2.4.z is, but playing safe is always good :)

}

if (bundler_version) {
withRVM(["gem install bundler -v '${bundler_version}' --no-document"], ruby, name)
} else {
Expand Down