Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Ruby 2.7 tests use dedicated bundler version #391

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Dec 15, 2023

Bundler 2.4.22 is last version to support Ruby 2.7 and needs to be directly installed to prevent an error resolving the supported version. This requirement occurred with the release of bundler 2.5.0.

Bundler 2.4.22 is last version to support Ruby 2.7 and needs to
be directly installed to prevent an error resolving the supported
version. This requirement occurred with the release of bundler 2.5.0.
@ehelms
Copy link
Member Author

ehelms commented Dec 15, 2023

Merging to unblock pull request and release workflows.

@ehelms ehelms merged commit 1d4dd26 into theforeman:master Dec 15, 2023
2 checks passed
@@ -15,6 +15,11 @@ def gemset(name = null) {

def configureRVM(ruby, name = '', bundler_version = null) {
emptyGemset(ruby, name)

if (ruby == '2.7') {
bundler_version = '2.4.22'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be < 2.5 to allow 2.4.z patches?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. But since you are asking, I am assuming maybe yes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

I have no idea how high the chances of a 2.4.z is, but playing safe is always good :)

@ekohl
Copy link
Member

ekohl commented Jan 3, 2024

non-pipeline jobs are still failing. https://github.com/theforeman/jenkins-jobs/tree/master/theforeman.org/scripts/test needs to be updated. @pcreech is working on that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants