-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 1 #168
Closed
Closed
Patch 1 #168
Commits on Sep 21, 2024
-
Remove lock_thread on connection pool
The commit that added lock_thread (f638085) notes that > Transaction management is largely ripped straight out of > test_fixtures.rb in Rails The commit that adds lock_thread in Rails -- rails/rails@d6466be -- has some helpful context: > When a system test starts Puma spins up one thread and Capybara spins > up another thread. Because of this when tests are run the database > cannot see what was inserted into the database on teardown. This is > because there are two threads using two different connections. > This change uses the statement cache to lock the threads to using a > single connection ID instead of each not being able to see each other. So lock_thread exists because there are two different threads -- Puma and Capybara -- trying to access the same database but not necessarily seeing the same thing. But! cypress-rails doesn't use Capybara, and more importantly, it doesn't use tests or a test runner written in Ruby at all, so there's only _one_ thread trying to use the database. So we don't need all this thread locking stuff. So let's remove it to make things more compatible with Rails 7.2.
Configuration menu - View commit details
-
Copy full SHA for d467efc - Browse repository at this point
Copy the full SHA d467efcView commit details
Commits on Sep 25, 2024
-
Use #lease_connection instead of #connection in Rails 7.2
Taken from #165, hence the coauthor credit. Co-authored-by: Georg Ledermann <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 67cf2bf - Browse repository at this point
Copy the full SHA 67cf2bfView commit details -
Support both Rails 7.1 and 7.2 in the example app
Use symlinks for multiple Gemfiles.
Configuration menu - View commit details
-
Copy full SHA for c1da259 - Browse repository at this point
Copy the full SHA c1da259View commit details -
Configuration menu - View commit details
-
Copy full SHA for 497d90d - Browse repository at this point
Copy the full SHA 497d90dView commit details -
Don't install example dependencies until we need to
This prevents us from installing gems in the example app that aren't needed by a different gemfile.
Configuration menu - View commit details
-
Copy full SHA for 312bc92 - Browse repository at this point
Copy the full SHA 312bc92View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf27fcd - Browse repository at this point
Copy the full SHA bf27fcdView commit details
Commits on Oct 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b14f81b - Browse repository at this point
Copy the full SHA b14f81bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.