Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #168

Closed
wants to merge 7 commits into from
Closed

Patch 1 #168

wants to merge 7 commits into from

Commits on Sep 21, 2024

  1. Remove lock_thread on connection pool

    The commit that added
    lock_thread (f638085) notes that
    > Transaction management is largely ripped straight out of
    > test_fixtures.rb in Rails
    
    The commit that adds lock_thread in Rails --
    rails/rails@d6466be
    -- has some helpful context:
    > When a system test starts Puma spins up one thread and Capybara spins
    > up another thread. Because of this when tests are run the database
    > cannot see what was inserted into the database on teardown. This is
    > because there are two threads using two different connections.
    
    > This change uses the statement cache to lock the threads to using a
    > single connection ID instead of each not being able to see each other.
    
    So lock_thread exists because there are two different threads -- Puma
    and Capybara -- trying to access the same database but not necessarily
    seeing the same thing. But! cypress-rails doesn't use Capybara, and more
    importantly, it doesn't use tests or a test runner written in Ruby at
    all, so there's only _one_ thread trying to use the database. So we
    don't need all this thread locking stuff. So let's remove it to make
    things more compatible with Rails 7.2.
    rosston committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    d467efc View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Use #lease_connection instead of #connection in Rails 7.2

    Taken from #165, hence
    the coauthor credit.
    
    Co-authored-by: Georg Ledermann <[email protected]>
    rosston and ledermann committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    67cf2bf View commit details
    Browse the repository at this point in the history
  2. Support both Rails 7.1 and 7.2 in the example app

    Use symlinks for multiple Gemfiles.
    rosston committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c1da259 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    497d90d View commit details
    Browse the repository at this point in the history
  4. Don't install example dependencies until we need to

    This prevents us from installing gems in the example app that aren't
    needed by a different gemfile.
    rosston committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    312bc92 View commit details
    Browse the repository at this point in the history
  5. Bump version to 0.8.0.rc1

    rosston committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bf27fcd View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Limit puma threads to 1

    azyzio authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    b14f81b View commit details
    Browse the repository at this point in the history