Patch 1 #168
Closed
Patch 1 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit that added lock_thread (f638085) notes that > Transaction management is largely ripped straight out of > test_fixtures.rb in Rails The commit that adds lock_thread in Rails -- rails/rails@d6466be -- has some helpful context: > When a system test starts Puma spins up one thread and Capybara spins > up another thread. Because of this when tests are run the database > cannot see what was inserted into the database on teardown. This is > because there are two threads using two different connections. > This change uses the statement cache to lock the threads to using a > single connection ID instead of each not being able to see each other. So lock_thread exists because there are two different threads -- Puma and Capybara -- trying to access the same database but not necessarily seeing the same thing. But! cypress-rails doesn't use Capybara, and more importantly, it doesn't use tests or a test runner written in Ruby at all, so there's only _one_ thread trying to use the database. So we don't need all this thread locking stuff. So let's remove it to make things more compatible with Rails 7.2.
Taken from #165, hence the coauthor credit. Co-authored-by: Georg Ledermann <[email protected]>
Use symlinks for multiple Gemfiles.
This prevents us from installing gems in the example app that aren't needed by a different gemfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.