Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto fix lint issues via CI #507

Merged
merged 3 commits into from
Oct 19, 2023
Merged

auto fix lint issues via CI #507

merged 3 commits into from
Oct 19, 2023

Conversation

neo773
Copy link
Contributor

@neo773 neo773 commented Oct 17, 2023

This PR adds lint:fix job that can be triggered via ci:lint label.

/claim #505

@tusharmath tusharmath added the ci: lint Automatically fix the linters issues and make a commit label Oct 18, 2023
@tusharmath
Copy link
Contributor

@neo773 the CI doesn't seem to be fixing the lint issues. Can you have a look

@neo773
Copy link
Contributor Author

neo773 commented Oct 18, 2023

@tusharmath
Had a successful run here https://github.com/neo773/tailcall/pull/10
I think the PR needs to be merged first so it has the proper permissions.

@ologbonowiwi
Copy link
Contributor

ologbonowiwi commented Oct 18, 2023

@tusharmath, you'll likely need to change the repo settings.

look at this comment on JamesIves/github-pages-deploy-action#1110; you'll need to set read and write on workflow permissions

@tusharmath tusharmath added maintenance and removed ci: lint Automatically fix the linters issues and make a commit labels Oct 19, 2023
@tusharmath tusharmath changed the title feat: add lint:fix in CI auto fix lint issues via CI Oct 19, 2023
@tusharmath tusharmath mentioned this pull request Oct 19, 2023
@tusharmath tusharmath merged commit faa72e9 into tailcallhq:main Oct 19, 2023
10 checks passed
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants