Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger lint via from CI #505

Closed
tusharmath opened this issue Oct 17, 2023 · 8 comments
Closed

Trigger lint via from CI #505

tusharmath opened this issue Oct 17, 2023 · 8 comments

Comments

@tusharmath
Copy link
Contributor

tusharmath commented Oct 17, 2023

  • We should be able to auto fix the PR by running the ./lint command.
  • This should only happen if a ci:lint label is added.
  • Once fixed, the new changes should be pushed.
  • This should happen independent to other builds.
@tusharmath
Copy link
Contributor Author

/bounty 30$

@algora-pbc
Copy link

algora-pbc bot commented Oct 17, 2023

💎 $30 bounty created by tusharmath
🙋 If you start working on this, comment /attempt #505 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #505 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to tailcallhq/tailcall!
🙋‍♂️ Join our discord channel if you need help.

Attempt Started (GMT+0) Solution
🟢 @adithyaakrishna Oct 19, 2023, 10:56:41 AM WIP
🟢 @ayewo Oct 19, 2023, 11:15:10 AM WIP
🟢 @neo773 #507

This was referenced Oct 17, 2023
@adithyaakrishna
Copy link

adithyaakrishna commented Oct 19, 2023

/attempt

Options

@adithyaakrishna
Copy link

@tusharmath How abt we add husky and lint-staged commands to do the lining on the contributor's side only? We can use pre-commit hooks 👀

@tusharmath
Copy link
Contributor Author

@adithyaakrishna was closed by #507

@ayewo
Copy link
Contributor

ayewo commented Oct 19, 2023

@neo773 looks like you forgot to add your /attempt #issue so that @algora-pbc can sync up your /claim #issue before triggering the automated payout.

(Talk about good ol' fashioned two-phase commit 😁).

Options

@algora-pbc
Copy link

algora-pbc bot commented Oct 19, 2023

🎉🎈 @neo773 has been awarded $30! 🎈🎊

@tusharmath
Copy link
Contributor Author

@adithyaakrishna I am not a fan of pre-commit hooks. You can always by pass them and otherwise they just slowdown the CLI experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants