Fix queue build up issue in gpsd_client #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In step() which is called periodically according to the parameter publish_rate we only perform read() once, which means that there could still be more unprocessed data from gpsd waiting. This leads to a build up of unprocessed data causing the published data to be old and outdated.
By instead using the waiting() call to see if there's more data to be processed we can make sure that what we publish is actually the newest available data.