bump codec sv2 version #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plebhash
force-pushed
the
patch-bump-codec-sv2
branch
from
3b8df52
to
b27345b
Compare
|
| Report | Thu, May 23, 2024 at 18:13:12 UTC |
| Project | Stratum v2 (SRI) |
| Branch | 927/merge |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| client-submit-serialize | ✅ (view plot) | 6,949.60 (+0.31%) | 7,272.11 (95.57%) |
| client-submit-serialize-deserialize | ✅ (view plot) | 7,949.80 (+1.34%) | 8,259.33 (96.25%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | ✅ (view plot) | 8,543.70 (+1.41%) | 8,819.87 (96.87%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | ✅ (view plot) | 902.12 (+0.37%) | 927.28 (97.29%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | ✅ (view plot) | 699.58 (+0.35%) | 717.81 (97.46%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | ✅ (view plot) | 244.78 (-1.19%) | 254.13 (96.32%) |
| client-sv1-get-authorize/client-sv1-get-authorize | ✅ (view plot) | 155.73 (-0.71%) | 160.12 (97.26%) |
| client-sv1-get-submit | ✅ (view plot) | 6,797.20 (+1.60%) | 7,035.67 (96.61%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | ✅ (view plot) | 272.91 (-1.91%) | 291.11 (93.75%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | ✅ (view plot) | 758.62 (+1.49%) | 776.49 (97.70%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | ✅ (view plot) | 608.62 (-0.96%) | 637.16 (95.52%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | ✅ (view plot) | 203.77 (-1.23%) | 219.81 (92.70%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Thu, May 23, 2024 at 18:13:16 UTC |
| Project | Stratum v2 (SRI) |
| Branch | patch-bump-codec-sv2 |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Upper Boundary accesses | (%) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | ✅ (view plot) | 8,489.00 (+0.81%) | 8,732.88 (97.21%) | ✅ (view plot) | 3,772.00 (+0.95%) | 3,862.30 (97.66%) | ✅ (view plot) | 5,294.00 (+1.05%) | 5,409.85 (97.86%) | ✅ (view plot) | 9.00 (+11.88%) | 10.53 (85.50%) | ✅ (view plot) | 90.00 (+0.27%) | 93.97 (95.78%) |
| get_submit | ✅ (view plot) | 95,614.00 (+0.07%) | 96,199.59 (99.39%) | ✅ (view plot) | 59,522.00 (+0.09%) | 59,809.37 (99.52%) | ✅ (view plot) | 85,494.00 (+0.11%) | 85,877.25 (99.55%) | ✅ (view plot) | 57.00 (+3.80%) | 62.32 (91.46%) | ✅ (view plot) | 281.00 (-0.37%) | 288.26 (97.48%) |
| get_subscribe | ✅ (view plot) | 8,032.00 (+0.80%) | 8,291.19 (96.87%) | ✅ (view plot) | 2,848.00 (+0.76%) | 2,948.18 (96.60%) | ✅ (view plot) | 3,977.00 (+0.70%) | 4,110.22 (96.76%) | ✅ (view plot) | 20.00 (+23.46%) | 20.08 (99.60%) | ✅ (view plot) | 113.00 (+0.43%) | 117.23 (96.40%) |
| serialize_authorize | ✅ (view plot) | 12,336.00 (+1.20%) | 12,503.54 (98.66%) | ✅ (view plot) | 5,343.00 (+0.67%) | 5,433.30 (98.34%) | ✅ (view plot) | 7,456.00 (+0.73%) | 7,573.56 (98.45%) | ✅ (view plot) | 10.00 (-7.98%) | 13.53 (73.92%) | ✅ (view plot) | 138.00 (+2.04%) | 139.99 (98.58%) |
| serialize_deserialize_authorize | ✅ (view plot) | 24,588.00 (+0.53%) | 24,714.34 (99.49%) | ✅ (view plot) | 9,950.00 (+0.56%) | 10,030.72 (99.20%) | ✅ (view plot) | 14,048.00 (+0.64%) | 14,154.70 (99.25%) | ✅ (view plot) | 36.00 (-2.35%) | 41.91 (85.90%) | ✅ (view plot) | 296.00 (+0.43%) | 297.67 (99.44%) |
| serialize_deserialize_handle_authorize | ✅ (view plot) | 30,184.00 (+0.17%) | 30,336.75 (99.50%) | ✅ (view plot) | 12,127.00 (+0.29%) | 12,217.30 (99.26%) | ✅ (view plot) | 17,164.00 (+0.31%) | 17,289.82 (99.27%) | ✅ (view plot) | 63.00 (+8.00%) | 64.32 (97.95%) | ✅ (view plot) | 363.00 (-0.20%) | 366.67 (99.00%) |
| serialize_deserialize_handle_submit | ✅ (view plot) | 126,525.00 (+0.09%) | 127,095.79 (99.55%) | ✅ (view plot) | 73,307.00 (+0.08%) | 73,657.26 (99.52%) | ✅ (view plot) | 105,085.00 (+0.10%) | 105,562.15 (99.55%) | ✅ (view plot) | 123.00 (+2.82%) | 130.49 (94.26%) | ✅ (view plot) | 595.00 (+0.01%) | 599.44 (99.26%) |
| serialize_deserialize_handle_subscribe | ✅ (view plot) | 27,476.00 (+0.09%) | 27,606.89 (99.53%) | ✅ (view plot) | 9,650.00 (+0.22%) | 9,750.18 (98.97%) | ✅ (view plot) | 13,646.00 (+0.20%) | 13,787.83 (98.97%) | ✅ (view plot) | 71.00 (+8.93%) | 71.90 (98.74%) | ✅ (view plot) | 385.00 (-0.23%) | 388.50 (99.10%) |
| serialize_deserialize_submit | ✅ (view plot) | 115,305.00 (+0.20%) | 115,697.90 (99.66%) | ✅ (view plot) | 68,167.00 (+0.17%) | 68,426.86 (99.62%) | ✅ (view plot) | 97,835.00 (+0.20%) | 98,178.84 (99.65%) | ✅ (view plot) | 71.00 (+2.90%) | 74.09 (95.83%) | ✅ (view plot) | 489.00 (+0.17%) | 492.75 (99.24%) |
| serialize_deserialize_subscribe | ✅ (view plot) | 22,968.00 (+0.44%) | 23,126.95 (99.31%) | ✅ (view plot) | 8,209.00 (+0.33%) | 8,305.45 (98.84%) | ✅ (view plot) | 11,563.00 (+0.34%) | 11,692.95 (98.89%) | ✅ (view plot) | 41.00 (+3.89%) | 44.41 (92.33%) | ✅ (view plot) | 320.00 (+0.49%) | 321.68 (99.48%) |
| serialize_submit | ✅ (view plot) | 100,033.00 (+0.15%) | 100,519.85 (99.52%) | ✅ (view plot) | 61,566.00 (+0.09%) | 61,859.50 (99.53%) | ✅ (view plot) | 88,338.00 (+0.10%) | 88,732.33 (99.56%) | ✅ (view plot) | 57.00 (+2.89%) | 61.02 (93.42%) | ✅ (view plot) | 326.00 (+0.43%) | 329.58 (98.91%) |
| serialize_subscribe | ✅ (view plot) | 11,459.00 (+1.26%) | 11,619.97 (98.61%) | ✅ (view plot) | 4,195.00 (+0.51%) | 4,295.18 (97.67%) | ✅ (view plot) | 5,834.00 (+0.45%) | 5,969.72 (97.73%) | ✅ (view plot) | 19.00 (+16.33%) | 19.19 (99.01%) | ✅ (view plot) | 158.00 (+1.89%) | 159.86 (98.84%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Thu, May 23, 2024 at 18:13:10 UTC |
| Project | Stratum v2 (SRI) |
| Branch | patch-bump-codec-sv2 |
| Testbed | sv2 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 45.19 (+1.44%) | 45.30 (99.76%) |
| client_sv2_handle_message_mining | ✅ (view plot) | 74.74 (+3.10%) | 80.37 (92.99%) |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 14.64 (-0.08%) | 14.69 (99.69%) |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 267.69 (+1.02%) | 285.49 (93.76%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 596.26 (+0.51%) | 624.08 (95.54%) |
| client_sv2_open_channel | ✅ (view plot) | 168.11 (+1.50%) | 171.66 (97.93%) |
| client_sv2_open_channel_serialize | ✅ (view plot) | 287.52 (+1.42%) | 293.53 (97.95%) |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 372.93 (-0.80%) | 403.21 (92.49%) |
| client_sv2_setup_connection | ✅ (view plot) | 166.37 (+1.29%) | 175.74 (94.67%) |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 471.00 (-0.62%) | 501.40 (93.94%) |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 951.73 (-2.26%) | 1,042.66 (91.28%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Thu, May 23, 2024 at 18:13:15 UTC |
| Project | Stratum v2 (SRI) |
| Branch | patch-bump-codec-sv2 |
| Testbed | sv2 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Upper Boundary accesses | (%) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 2,027.00 (-0.92%) | 2,128.24 (95.24%) | ✅ (view plot) | 473.00 (+0.57%) | 487.45 (97.04%) | ✅ (view plot) | 737.00 (+0.70%) | 757.22 (97.33%) | ✅ (view plot) | 6.00 (-11.18%) | 10.30 (58.24%) | ✅ (view plot) | 36.00 (-1.58%) | 38.65 (93.15%) |
| client_sv2_handle_message_mining | ✅ (view plot) | 8,211.00 (+0.19%) | 8,349.13 (98.35%) | ✅ (view plot) | 2,137.00 (+0.55%) | 2,172.82 (98.35%) | ✅ (view plot) | 3,161.00 (+0.63%) | 3,217.94 (98.23%) | ✅ (view plot) | 37.00 (-4.97%) | 43.54 (84.99%) | ✅ (view plot) | 139.00 (+0.11%) | 142.33 (97.66%) |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 6,220.00 (-0.97%) | 6,402.31 (97.15%) | ✅ (view plot) | 1,750.00 (+0.03%) | 1,764.51 (99.18%) | ✅ (view plot) | 2,555.00 (+0.06%) | 2,577.72 (99.12%) | ✅ (view plot) | 19.00 (+8.37%) | 22.67 (83.81%) | ✅ (view plot) | 102.00 (-1.92%) | 107.31 (95.05%) |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 14,795.00 (+0.16%) | 15,048.81 (98.31%) | ✅ (view plot) | 4,694.00 (+0.01%) | 4,708.51 (99.69%) | ✅ (view plot) | 6,755.00 (+0.01%) | 6,777.41 (99.67%) | ✅ (view plot) | 47.00 (-0.56%) | 52.08 (90.24%) | ✅ (view plot) | 223.00 (+0.32%) | 230.36 (96.80%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 27,518.00 (+0.18%) | 27,868.28 (98.74%) | ✅ (view plot) | 10,545.00 (+0.04%) | 10,559.39 (99.86%) | ✅ (view plot) | 15,343.00 (+0.03%) | 15,362.54 (99.87%) | ✅ (view plot) | 83.00 (-0.69%) | 89.51 (92.73%) | ✅ (view plot) | 336.00 (+0.40%) | 346.04 (97.10%) |
| client_sv2_open_channel | ✅ (view plot) | 4,497.00 (+0.19%) | 4,613.58 (97.47%) | ✅ (view plot) | 1,461.00 (+0.06%) | 1,475.77 (99.00%) | ✅ (view plot) | 2,152.00 (-0.03%) | 2,174.95 (98.94%) | ✅ (view plot) | 14.00 (+17.98%) | 15.34 (91.26%) | ✅ (view plot) | 65.00 (-0.07%) | 68.23 (95.27%) |
| client_sv2_open_channel_serialize | ✅ (view plot) | 14,232.00 (+0.13%) | 14,469.50 (98.36%) | ✅ (view plot) | 5,064.00 (+0.02%) | 5,078.77 (99.71%) | ✅ (view plot) | 7,317.00 (-0.01%) | 7,341.51 (99.67%) | ✅ (view plot) | 39.00 (+5.28%) | 41.51 (93.96%) | ✅ (view plot) | 192.00 (+0.14%) | 199.11 (96.43%) |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 22,690.00 (+0.25%) | 23,047.77 (98.45%) | ✅ (view plot) | 7,987.00 (+0.06%) | 8,001.94 (99.81%) | ✅ (view plot) | 11,610.00 (-0.03%) | 11,638.64 (99.75%) | ✅ (view plot) | 81.00 (+11.23%) | 81.64 (99.22%) | ✅ (view plot) | 305.00 (+0.18%) | 315.62 (96.63%) |
| client_sv2_setup_connection | ✅ (view plot) | 4,669.00 (-0.64%) | 4,771.06 (97.86%) | ✅ (view plot) | 1,502.00 (+0.06%) | 1,516.77 (99.03%) | ✅ (view plot) | 2,279.00 (+0.10%) | 2,301.77 (99.01%) | ✅ (view plot) | 9.00 (-1.22%) | 13.53 (66.50%) | ✅ (view plot) | 67.00 (-1.34%) | 69.74 (96.07%) |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 16,346.00 (+0.55%) | 16,468.31 (99.26%) | ✅ (view plot) | 5,963.00 (+0.02%) | 5,977.77 (99.75%) | ✅ (view plot) | 8,651.00 (-0.05%) | 8,679.92 (99.67%) | ✅ (view plot) | 48.00 (+8.11%) | 48.92 (98.13%) | ✅ (view plot) | 213.00 (+1.02%) | 216.78 (98.26%) |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 35,596.00 (+0.19%) | 35,751.29 (99.57%) | ✅ (view plot) | 14,814.00 (+0.03%) | 14,828.94 (99.90%) | ✅ (view plot) | 21,751.00 (+0.00%) | 21,774.67 (99.89%) | ✅ (view plot) | 102.00 (+3.38%) | 111.91 (91.14%) | ✅ (view plot) | 381.00 (+0.38%) | 384.52 (99.09%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
Since it was a patch, why |
#848 was not a patch, it added docs and renamed/cleaned up some code maybe the name I gave to my branch is misleading indeed, sorry about that |
plebhash
force-pushed
the
patch-bump-codec-sv2
branch
from
b27345b
to
70afabc
Compare
GitGab19
approved these changes
May 23, 2024
Closed
This was referenced May 23, 2024
Merged
Fi3
pushed a commit
that referenced
this pull request
May 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while fixing
check-versioning-lib-release.sh(#926) and preparing for Releasev1.0.1(#925), I noticed we were forgetting to bumpcodec_sv2crate version, as a result of a patch applied to one of it's dependencies (framing_sv2) via #913framing_sv2(which is a dependency ofcodec_sv2) had it'sMINORversion bumped, which meanscodec_sv2also needs to bump it'sMINORversion