Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cargo.lock files with version updates #933

Merged
merged 2 commits into from
May 27, 2024

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented May 25, 2024

As we prepare for Release v1.0.1 (#925), we recently bumped the versions for a few modified crates:

I made a mistake on those PRs: I forgot to run cargo build to update all Cargo.lock files that list these crates as dependencies.

This also happened on Release v1.0.0 and Cargo.lock became PITA as a result.

This PR should avoid repeating this mistake on Release v1.0.1.


Also, as I built the examples and utils crates, I noticed git was trying to commit some target directories and Cargo.lock files. So this PR also fixes .gitignore such that those files are now ignored by git.

@plebhash plebhash changed the title Update cargo lock Update Cargo.lock files with version updates May 25, 2024
@plebhash plebhash changed the base branch from main to dev May 25, 2024 22:04
Copy link
Contributor

github-actions bot commented May 25, 2024

🐰Bencher

ReportMon, May 27, 2024 at 13:41:48 UTC
ProjectStratum v2 (SRI)
Branchupdate-cargo-lock
Testbedsv1

🚨 4 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
get_subscribeL2 Accesses (accesses)🚨 (view plot | view alert)20.00 (+23.55%)19.76 (101.21%)
serialize_deserialize_handle_subscribeL2 Accesses (accesses)🚨 (view plot | view alert)75.00 (+14.14%)73.52 (102.02%)
serialize_submitL2 Accesses (accesses)🚨 (view plot | view alert)63.00 (+13.22%)61.67 (102.15%)
serialize_subscribeL2 Accesses (accesses)🚨 (view plot | view alert)20.00 (+22.61%)18.98 (105.40%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,459.00 (+0.40%)8,729.75 (96.90%)✅ (view plot)3,772.00 (+0.92%)3,859.74 (97.73%)✅ (view plot)5,294.00 (+1.02%)5,406.38 (97.92%)✅ (view plot)10.00 (+23.08%)10.63 (94.12%)✅ (view plot)89.00 (-0.93%)93.98 (94.70%)
get_submit✅ (view plot)95,562.00 (+0.01%)96,181.96 (99.36%)✅ (view plot)59,522.00 (+0.09%)59,798.46 (99.54%)✅ (view plot)85,492.00 (+0.11%)85,862.22 (99.57%)✅ (view plot)61.00 (+10.66%)62.58 (97.48%)✅ (view plot)279.00 (-1.11%)288.19 (96.81%)
get_subscribe✅ (view plot)7,964.00 (-0.10%)8,286.33 (96.11%)✅ (view plot)2,848.00 (+0.72%)2,945.46 (96.69%)✅ (view plot)3,979.00 (+0.72%)4,106.67 (96.89%)🚨 (view plot | view alert)20.00 (+23.55%)19.76 (101.21%)✅ (view plot)111.00 (-1.41%)117.22 (94.69%)
serialize_authorize✅ (view plot)12,280.00 (+0.72%)12,498.77 (98.25%)✅ (view plot)5,343.00 (+0.65%)5,430.74 (98.38%)✅ (view plot)7,455.00 (+0.70%)7,570.08 (98.48%)✅ (view plot)13.00 (+18.63%)13.65 (95.24%)✅ (view plot)136.00 (+0.54%)139.93 (97.19%)
serialize_deserialize_authorize✅ (view plot)24,494.00 (+0.14%)24,707.48 (99.14%)✅ (view plot)9,950.00 (+0.55%)10,028.49 (99.22%)✅ (view plot)14,049.00 (+0.64%)14,151.99 (99.27%)✅ (view plot)38.00 (+2.88%)41.94 (90.61%)✅ (view plot)293.00 (-0.58%)297.63 (98.44%)
serialize_deserialize_handle_authorize✅ (view plot)30,120.00 (-0.06%)30,340.09 (99.27%)✅ (view plot)12,127.00 (+0.29%)12,214.74 (99.28%)✅ (view plot)17,165.00 (+0.30%)17,286.01 (99.30%)✅ (view plot)64.00 (+9.32%)64.62 (99.04%)✅ (view plot)361.00 (-0.77%)366.84 (98.41%)
serialize_deserialize_handle_submit✅ (view plot)126,435.00 (+0.02%)127,075.27 (99.50%)✅ (view plot)73,307.00 (+0.08%)73,644.30 (99.54%)✅ (view plot)105,085.00 (+0.10%)105,544.13 (99.56%)✅ (view plot)126.00 (+4.95%)131.19 (96.04%)✅ (view plot)592.00 (-0.50%)599.50 (98.75%)
serialize_deserialize_handle_subscribe✅ (view plot)27,390.00 (-0.23%)27,611.76 (99.20%)✅ (view plot)9,650.00 (+0.21%)9,747.46 (99.00%)✅ (view plot)13,645.00 (+0.18%)13,783.30 (99.00%)🚨 (view plot | view alert)75.00 (+14.14%)73.52 (102.02%)✅ (view plot)382.00 (-1.00%)388.72 (98.27%)
serialize_deserialize_submit✅ (view plot)115,249.00 (+0.15%)115,679.14 (99.63%)✅ (view plot)68,167.00 (+0.17%)68,416.89 (99.63%)✅ (view plot)97,834.00 (+0.20%)98,165.90 (99.66%)✅ (view plot)74.00 (+6.83%)74.72 (99.04%)✅ (view plot)487.00 (-0.24%)492.70 (98.84%)
serialize_deserialize_subscribe✅ (view plot)22,874.00 (+0.02%)23,120.17 (98.94%)✅ (view plot)8,209.00 (+0.31%)8,302.77 (98.87%)✅ (view plot)11,564.00 (+0.33%)11,689.37 (98.93%)✅ (view plot)43.00 (+8.75%)44.40 (96.85%)✅ (view plot)317.00 (-0.45%)321.63 (98.56%)
serialize_submit✅ (view plot)99,955.00 (+0.07%)100,502.08 (99.46%)✅ (view plot)61,566.00 (+0.09%)61,848.35 (99.54%)✅ (view plot)88,335.00 (+0.10%)88,716.88 (99.57%)🚨 (view plot | view alert)63.00 (+13.22%)61.67 (102.15%)✅ (view plot)323.00 (-0.50%)329.50 (98.03%)
serialize_subscribe✅ (view plot)11,361.00 (+0.38%)11,612.69 (97.83%)✅ (view plot)4,195.00 (+0.49%)4,292.46 (97.73%)✅ (view plot)5,836.00 (+0.46%)5,966.22 (97.82%)🚨 (view plot | view alert)20.00 (+22.61%)18.98 (105.40%)✅ (view plot)155.00 (-0.05%)159.78 (97.01%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented May 25, 2024

🐰Bencher

ReportMon, May 27, 2024 at 13:41:49 UTC
ProjectStratum v2 (SRI)
Branch933/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)7,093.00 (+2.33%)7,290.64 (97.29%)
client-submit-serialize-deserialize✅ (view plot)8,157.60 (+3.86%)8,292.92 (98.37%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,792.80 (+4.27%)8,856.94 (99.28%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)892.20 (-0.68%)926.93 (96.25%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)689.09 (-1.09%)718.06 (95.96%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)247.26 (-0.25%)254.33 (97.22%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)158.72 (+1.18%)160.24 (99.05%)
client-sv1-get-submit✅ (view plot)6,972.90 (+4.17%)7,060.42 (98.76%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)275.14 (-1.25%)291.44 (94.41%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)741.44 (-0.74%)776.43 (95.49%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)601.77 (-2.05%)638.01 (94.32%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)203.79 (-1.37%)220.17 (92.56%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented May 25, 2024

🐰Bencher

ReportMon, May 27, 2024 at 13:41:49 UTC
ProjectStratum v2 (SRI)
Branchupdate-cargo-lock
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2,065.00 (+0.87%)2,127.59 (97.06%)✅ (view plot)473.00 (+0.54%)487.09 (97.11%)✅ (view plot)735.00 (+0.40%)756.55 (97.15%)✅ (view plot)7.00 (+2.75%)10.25 (68.28%)✅ (view plot)37.00 (+1.08%)38.61 (95.82%)
client_sv2_handle_message_mining✅ (view plot)8,203.00 (+0.10%)8,341.00 (98.35%)✅ (view plot)2,137.00 (+0.52%)2,172.34 (98.37%)✅ (view plot)3,163.00 (+0.65%)3,217.69 (98.30%)✅ (view plot)35.00 (-9.48%)43.61 (80.26%)✅ (view plot)139.00 (+0.14%)142.11 (97.81%)
client_sv2_mining_message_submit_standard✅ (view plot)6,242.00 (-0.56%)6,395.97 (97.59%)✅ (view plot)1,750.00 (+0.03%)1,764.04 (99.20%)✅ (view plot)2,557.00 (+0.12%)2,577.30 (99.21%)✅ (view plot)16.00 (-8.02%)22.40 (71.43%)✅ (view plot)103.00 (-0.86%)107.13 (96.15%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,825.00 (+0.35%)15,043.64 (98.55%)✅ (view plot)4,694.00 (+0.01%)4,708.04 (99.70%)✅ (view plot)6,755.00 (+0.01%)6,776.75 (99.68%)✅ (view plot)46.00 (-2.43%)51.85 (88.72%)✅ (view plot)224.00 (+0.73%)230.24 (97.29%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,522.00 (+0.18%)27,860.27 (98.79%)✅ (view plot)10,545.00 (+0.04%)10,559.15 (99.87%)✅ (view plot)15,342.00 (+0.02%)15,361.99 (99.87%)✅ (view plot)84.00 (+0.45%)89.31 (94.06%)✅ (view plot)336.00 (+0.37%)345.80 (97.17%)
client_sv2_open_channel✅ (view plot)4,527.00 (+0.80%)4,613.26 (98.13%)✅ (view plot)1,461.00 (+0.06%)1,475.30 (99.03%)✅ (view plot)2,152.00 (-0.03%)2,174.18 (98.98%)✅ (view plot)13.00 (+9.09%)15.28 (85.08%)✅ (view plot)66.00 (+1.38%)68.22 (96.74%)
client_sv2_open_channel_serialize✅ (view plot)14,262.00 (+0.32%)14,465.48 (98.59%)✅ (view plot)5,064.00 (+0.02%)5,078.30 (99.72%)✅ (view plot)7,317.00 (-0.01%)7,340.68 (99.68%)✅ (view plot)38.00 (+2.36%)41.62 (91.30%)✅ (view plot)193.00 (+0.62%)198.97 (97.00%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,700.00 (+0.29%)23,037.78 (98.53%)✅ (view plot)7,987.00 (+0.05%)8,001.71 (99.82%)✅ (view plot)11,615.00 (+0.02%)11,637.95 (99.80%)✅ (view plot)75.00 (+2.80%)81.45 (92.08%)✅ (view plot)306.00 (+0.49%)315.33 (97.04%)
client_sv2_setup_connection✅ (view plot)4,699.00 (+0.00%)4,768.72 (98.54%)✅ (view plot)1,502.00 (+0.06%)1,516.30 (99.06%)✅ (view plot)2,279.00 (+0.10%)2,301.13 (99.04%)✅ (view plot)8.00 (-11.32%)13.34 (59.96%)✅ (view plot)68.00 (+0.12%)69.69 (97.58%)
client_sv2_setup_connection_serialize✅ (view plot)16,372.00 (+0.67%)16,475.71 (99.37%)✅ (view plot)5,963.00 (+0.01%)5,977.30 (99.76%)✅ (view plot)8,652.00 (-0.04%)8,678.98 (99.69%)✅ (view plot)46.00 (+3.56%)48.70 (94.45%)✅ (view plot)214.00 (+1.40%)217.00 (98.62%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,608.00 (+0.22%)35,749.56 (99.60%)✅ (view plot)14,814.00 (+0.03%)14,828.71 (99.90%)✅ (view plot)21,748.00 (-0.01%)21,773.86 (99.88%)✅ (view plot)105.00 (+6.08%)112.09 (93.68%)✅ (view plot)381.00 (+0.37%)384.46 (99.10%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented May 25, 2024

🐰Bencher

ReportMon, May 27, 2024 at 13:41:48 UTC
ProjectStratum v2 (SRI)
Branchupdate-cargo-lock
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.75 (+0.46%)45.25 (98.90%)
client_sv2_handle_message_mining✅ (view plot)72.91 (+0.48%)80.31 (90.79%)
client_sv2_mining_message_submit_standard✅ (view plot)14.63 (-0.13%)14.69 (99.62%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)266.11 (+0.59%)284.86 (93.42%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)578.12 (-2.57%)625.13 (92.48%)
client_sv2_open_channel✅ (view plot)165.43 (-0.14%)171.45 (96.49%)
client_sv2_open_channel_serialize✅ (view plot)285.02 (+0.50%)293.50 (97.11%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)372.68 (-0.85%)402.38 (92.62%)
client_sv2_setup_connection✅ (view plot)159.22 (-3.04%)175.42 (90.77%)
client_sv2_setup_connection_serialize✅ (view plot)470.32 (-0.86%)503.03 (93.50%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)936.91 (-3.64%)1,040.70 (90.03%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

examples/ping-pong-with-noise/Cargo.lock Outdated Show resolved Hide resolved
examples/interop-cpp/Cargo.lock Outdated Show resolved Hide resolved
examples/ping-pong-without-noise/Cargo.lock Outdated Show resolved Hide resolved
utils/message-generator/Cargo.lock Outdated Show resolved Hide resolved
@plebhash plebhash requested a review from GitGab19 May 27, 2024 13:38
@plebhash plebhash mentioned this pull request May 27, 2024
.gitignore Show resolved Hide resolved
@pavlenex pavlenex added this to the 1.0.1 milestone May 27, 2024
@plebhash plebhash merged commit d613473 into stratum-mining:dev May 27, 2024
13 checks passed
@plebhash plebhash deleted the update-cargo-lock branch May 27, 2024 14:43
Fi3 pushed a commit that referenced this pull request May 28, 2024
@plebhash plebhash mentioned this pull request May 28, 2024
@plebhash plebhash mentioned this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

3 participants