Default to cores max protocol version in local mode when no default specified #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Default to cores max protocol version in local mode when no default specified.
Why
In #594 I removed the automatic default and replaced it with an explicit default because nearing protocol releases we have versions of software being updated in quickstart without coordination, which is good, and having local always startup a network based on core's max supported protocol version meant that in some cases it would start networks that the image as a whole was not ready to run.
When I removed the automatic default I made it so that an explicit default had to be set. That requirement was somewhat unnecessary. For most uses of quickstart simply using what core thinks the version should be is fine, and it's those edge cases where we need it specified.
I'd like to keep it as so so that in other uses of quickstart, like the system-tests, don't need to also coordinate the default version in their default configuration and can rely on quickstart figuring it out for the common case.
Related: