Set the PROTOCOL_VERSION_DEFAULT when building quickstart #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Set the PROTOCOL_VERSION_DEFAULT when building quickstart.
Why
The quickstart image now requires the default protocol version to be set as a build argument. This is because the quickstart image can't know what the common maximum supported protocol version is of all of the software in the image. It may be that a stellar-core has support for N, while a Horizon or RPC may only support N-1. We want teams to be able to update their software without coordinating, and for the image still to work if it has a newer stellar-core while it has an older Horizon.
The system-test image builds quickstart and so needs to set this new parameter.
Related: