Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for @stdlib/stats/base/dists/bernoulli/entropy #3449

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

vivekmaurya001
Copy link
Contributor

@vivekmaurya001 vivekmaurya001 commented Dec 11, 2024

Resolves #3412.

Description

  • adds C implementation for @stdlib/stats/base/dists/bernoulli/entropy along with relevant tests, benchmarks and examples

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 11, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 11, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/bernoulli/entropy $\color{green}178/178$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}178/178$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vivekmaurya001 Before opening many simultaneous PRs, please prioritize improving your existing PRs. Many of the mistakes flagged in this PR will need to be corrected across your other PRs. You'll save yourself (and us!) work and time by getting things right the first time.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 11, 2024
@vivekmaurya001
Copy link
Contributor Author

@kgryte , I understand my mistake , I am correcting it

@vivekmaurya001
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 11, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 11, 2024
@vivekmaurya001
Copy link
Contributor Author

@kgryte , changes done please give a look !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/bernoulli/entropy
3 participants