-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: numpy 2 and astropy 6.1 compat, bump minversions #387
Conversation
and bump minversion of Python and dependencies.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
==========================================
+ Coverage 96.83% 97.21% +0.37%
==========================================
Files 17 17
Lines 2056 2047 -9
==========================================
- Hits 1991 1990 -1
+ Misses 65 57 -8 ☔ View full report in Codecov by Sentry. |
@ariedel , does ETC team want to take this for a spin before I merge? This builds synphot C-ext against numpy 2.x ABI but should still be compatible with numpy 1.x to some degree. |
Please let me know if you also need an accompanying stsynphot PR though I don't see why because stsynphot does not have C-extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ETC still uses numpy 1.x, but I've taken this branch for a spin and the ETC functions perfectly well with the changes.
Description
This pull request is to address impending numpy 2.0 release.
Fixes #386