Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build workflow - (issue #52) #53

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Update build workflow - (issue #52) #53

merged 1 commit into from
Sep 9, 2024

Conversation

mkhansenbot
Copy link
Contributor

Change directory before running build flow (issue #52)

@mkhansenbot mkhansenbot marked this pull request as ready for review September 9, 2024 16:22
EzraBrooks
EzraBrooks approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@EzraBrooks EzraBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall using pushd and popd instead of cd in cases like this being the "correct" solution, but this seems like it works fine.

@mkhansenbot mkhansenbot merged commit 981bd60 into space-ros:main Sep 9, 2024
1 check passed
@Bckempa Bckempa added this to the jazzy-2024.10.0 milestone Sep 15, 2024
@Bckempa Bckempa linked an issue Sep 15, 2024 that may be closed by this pull request
Enhance Docker Image build workflow to change directories before running build scripts #52
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzraBrooks EzraBrooks EzraBrooks approved these changes

@Bckempa Bckempa Awaiting requested review from Bckempa

Assignees
No one assigned
Labels
None yet
Projects
Space ROS Project Development
Status: Done
Milestone
humble-2024.10.0
Development

Successfully merging this pull request may close these issues.

Enhance Docker Image build workflow to change directories before running build scripts
3 participants
@mkhansenbot @EzraBrooks @Bckempa