Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Docker Image build workflow to change directories before running build scripts #52

Closed
mkhansenbot opened this issue Sep 9, 2024 · 0 comments · Fixed by #53
Closed

Enhance Docker Image build workflow to change directories before running build scripts #52

mkhansenbot opened this issue Sep 9, 2024 · 0 comments · Fixed by #53
Assignees
@mkhansenbot
Labels
enhancement New feature or request
Milestone
humble-2024.10.0

Comments

@mkhansenbot
Copy link
Contributor

Feature description

For some image builds, it's necessary to run the build.sh file from the folder containing the file. For this reason, the GH Action build should cd into the folder with the build script before running it

Implementation considerations

Adding this should enable PRs #41 and #45 to build, among others
@mkhansenbot mkhansenbot added the enhancement New feature or request label Sep 9, 2024
@mkhansenbot mkhansenbot self-assigned this Sep 9, 2024
mkhansenbot added a commit to mkhansenbot/space-ros-demos that referenced this issue Sep 9, 2024
@mkhansenbot
Change dir before running build script (issue space-ros#52)
7e82581
@mkhansenbot mkhansenbot mentioned this issue Sep 9, 2024
Merged
mkhansenbot added a commit that referenced this issue Sep 9, 2024
@mkhansenbot
Merge pull request #53 from mkhansenbot/update-build-workflow
981bd60 
Update build workflow - (issue #52)
gmacario pushed a commit to B-AROL-O/space-ros-demos that referenced this issue Sep 9, 2024
@mkhansenbot @gmacario
Change dir before running build script (issue space-ros#52)
4bd0b23
@Bckempa Bckempa added this to the jazzy-2024.10.0 milestone Sep 15, 2024
@Bckempa Bckempa linked a pull request Sep 15, 2024 that will close this issue
Update build workflow - (issue #52) #53
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkhansenbot mkhansenbot

Labels
enhancement New feature or request
Projects
Space ROS Project Development
Status: Done
Milestone
humble-2024.10.0
Development

Successfully merging a pull request may close this issue.

Update build workflow - (issue #52) mkhansenbot/space-ros-demos
2 participants
@Bckempa @mkhansenbot