Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prism cython #67

Merged
merged 12 commits into from
Oct 30, 2023
Merged

Prism cython #67

merged 12 commits into from
Oct 30, 2023

Conversation

jcapriot
Copy link
Member

Updates the prism functions to use cython instead of C... two reasons:

  1. The compiled prism functions are still numpy ufuncs, but writing them in cython will make it much easier for someone besides myself to digest.
  2. Writing them in cython allows us to do some fancy magic to get them to work simultaneously with numba.njit!

In this PR I've registered them so that numba should know what to do with them.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #67 (3cf25a7) into main (5408065) will increase coverage by 0.00%.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   87.47%   87.47%           
=======================================
  Files          29       30    +1     
  Lines        3043     3067   +24     
=======================================
+ Hits         2662     2683   +21     
- Misses        381      384    +3     
Files Coverage Δ
geoana/kernels/_extensions/__init__.py 87.50% <87.50%> (ø)

@jcapriot jcapriot merged commit 0d2a7da into simpeg:main Oct 30, 2023
7 checks passed
@jcapriot jcapriot deleted the prism_cython branch October 30, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant