-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links for shipwright-io/build references #115
base: main
Are you sure you want to change the base?
Conversation
/assign @adambkaplan |
/kind documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there are two types of changes, one for the broken links and the other is newly added YAMLs.
I would suggest breaking it into at least two commits clearly showing the specific change. Rest looks good to me.
@avinal actually the addition of samples/ is done with the same intention of fixing the broken links (for example: https://github.com/shipwright-io/website/blob/main/content/en/docs/build/buildstrategies.md). |
eb6b695
to
5e0a21b
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I just realised, that the tests have been failing since my last push. I am currently working on it & shall push the changes soon. |
5e0a21b
to
ca52c37
Compare
Blocked by #127 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apoorvajagtap is there a reason why docsy
is being updated here?
I also see a lot of other changes that go well beyond the scope of "fixing broken links" - can you explain this further in the body of your commit message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, docsy changes should be moved to a separate PR.
Changes
The buildstrategies.md references multiple examples of build/samples/v1beta1 directory. This PR copies the contents from the build/samples to the current project. This would aid the manual syncs (until we automate) in case of any new changes instead of updating the multiple links each time.
In addition to samples, references to controller.yaml are also updated to refer to the correct link per #113.
Follow up of #113
-->
Submitter Checklist
Release Notes