Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated terms from config.toml #112

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Remove deprecated terms from config.toml #112

merged 1 commit into from
Sep 4, 2024

Conversation

apoorvajagtap
Copy link
Member

@apoorvajagtap apoorvajagtap commented Mar 27, 2024 •
edited
Loading

Changes

Removes deprecated variables from config.toml

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2024
HeavyWombat
HeavyWombat requested changes May 10, 2024
View reviewed changes
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apoorvajagtap Apologies, this somehow went under my radar. Do you have any docs that you can link with regards to this change, where for example the deprecation is explained. Also, there seems to be a build failure. Any idea what this might be caused by:

8:46:00 AM: "build.command" failed                                        
8:46:00 AM: ────────────────────────────────────────────────────────────────
8:46:00 AM: ​
8:46:00 AM:   Error message
8:46:00 AM:   Command failed with exit code 2: make netlify-preview (https://ntl.fyi/exit-code-2)
8:46:00 AM: ​
8:46:00 AM:   Error location
8:46:00 AM:   In build.command from netlify.toml:
8:46:00 AM:   make netlify-preview
8:46:00 AM: ​
8:46:00 AM:   Resolved config
8:46:00 AM:   build:
8:46:00 AM:     command: make netlify-preview
8:46:00 AM:     commandOrigin: config
8:46:00 AM:     environment:
8:46:00 AM:       - HUGO_VERSION
8:46:00 AM:       - REVIEW_ID
8:46:00 AM:     publish: /opt/build/repo/public
8:46:00 AM:     publishOrigin: config
8:46:01 AM: Failed during stage "building site": Build script returned non-zero exit code: 2
8:46:01 AM: Build failed due to a user error: Build script returned non-zero exit code: 2
8:46:01 AM: Failing build: Failed to build site
8:46:01 AM: Finished processing build request in 2m35.385s

@apoorvajagtap
Copy link
Member Author

apoorvajagtap commented May 13, 2024 •
edited
Loading

Hi @HeavyWombat linking the release notes & related issue where these changes were introduced.
And I realized that I missed adding "term" as a replacement for "taxonomy" which might have led to the build failure. Let me know your thoughts!

Also, the errors indicate that the custom params on the language top level were deprecated in Hugo v0.112.0 and will be removed in Hugo 0.125.0. So, it is expected to put the value below [languages.en.params]. See https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120

HeavyWombat
HeavyWombat requested changes May 14, 2024
View reviewed changes
config.toml Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2024
@apoorvajagtap
remove deprecated terms
06477a9 
With hugo v0.73.0 https://github.com/gohugoio/hugo/releases/tag/v0.73.0,
the following values were replaced:
taxonomy -> term & taxonomyTerm -> taxonomy

With hugo v0.112.0 custom parameters are to be defined within languages.xx.params
https://gohugo.io/content-management/multilingual/#changes-in-hugo-01120
@apoorvajagtap apoorvajagtap mentioned this pull request Aug 5, 2024
Closed
HeavyWombat
HeavyWombat approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
SaschaSchwarze0
SaschaSchwarze0 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 74b4f30 into shipwright-io:main Sep 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@HeavyWombat HeavyWombat HeavyWombat approved these changes

Assignees

@HeavyWombat HeavyWombat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apoorvajagtap @HeavyWombat @SaschaSchwarze0