Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update custom_indicators.Rmd #32

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Update custom_indicators.Rmd #32

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db57f8e
Update custom_indicators.Rmd
stavralf Aug 19, 2024
b4b846f
Update custom_indicators.Rmd
serkor1 Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions vignettes/custom_indicators.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ knitr::opts_chunk$set(

```{r setup}
library(cryptoQuotes)
library(dplyr)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a shame to declare a dependency on dplyr just for this PR. I suggest that you post your PR without dplyr.

```

Trading indicators comes in various forms; from the alignment of the moon relative to the sun, to sophisticated trading rules based on neural networks which incorporates classified features; It is not possible to cover them all in an `R` package.
Expand All @@ -39,15 +40,18 @@ We start by creating a simple `chart`-object with `volume` as it's only indicato
# 1) create a simple chart
# object
chart_object <- chart(
ticker = BTC,
ticker = BTC ,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this additional white space; I spend many hours on spotting these. It triggers my OCD 🤣

main = kline(),
sub = list(
volume()
),
options = list(
dark = FALSE
)
)
)%>%
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not use %>% at all, so please avoid using it in the vignette!

layout(xaxis = list(showticklabels=FALSE))
stavralf marked this conversation as resolved.
Show resolved Hide resolved



# 2) display the chart
chart_object
Expand Down